Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Extract deceased information parsing into its own function #106

Closed
rgreinho opened this issue Apr 29, 2019 · 2 comments · Fixed by #136
Closed

Extract deceased information parsing into its own function #106

rgreinho opened this issue Apr 29, 2019 · 2 comments · Fixed by #136
Labels
exp/beginner Good for newcomers kind/enhancement Improve an existing feature status/claimed Assigned
Projects
Maintaince mode or second milestone
Milestone
1.5.2 - Keep the ...

Comments

@rgreinho
Copy link
Member

Issue Type

  • Feature request

Current Behavior

All the regexes detecting the fields are part of a single functions looping through the regexes.

Expected Behavior

Possible Solution

  • Create a dedicated function containing the regex in verbose mode.
  • Add dedicated test with several test cases.
@rgreinho rgreinho added kind/enhancement Improve an existing feature exp/beginner Good for newcomers labels Apr 29, 2019
@rgreinho rgreinho added this to the 1.5.2 - Keep the code clean milestone Apr 29, 2019
@rgreinho rgreinho added this to To do in Maintaince mode or second milestone via automation Apr 29, 2019
@anthonybaulo
Copy link
Member

@rgreinho I'd like to work on this issue

@rgreinho rgreinho added the status/claimed Assigned label Jun 6, 2019
@rgreinho rgreinho moved this from To do to In progress in Maintaince mode or second milestone Jun 6, 2019
@anthonybaulo anthonybaulo mentioned this issue Jun 6, 2019
Merged
2 tasks
anthonybaulo added a commit to anthonybaulo/scrapd that referenced this issue Jun 7, 2019
@anthonybaulo
Extract deceased parsing to its own function
75dcb69 
The function parse_deceased_field() was created to pull content from the
corresponding field on the fatality page. There was an existing function
of the same name, which has now been renamed process_deceased_field().
Test cases have been made for the new parse_deceased_field().

Fixes scrapd#106
anthonybaulo added a commit to anthonybaulo/scrapd that referenced this issue Jun 8, 2019
@anthonybaulo
Add check for deceased field
e56919b 
The deceased field will not be created in the dictionary
unless a match was found.

Fixes scrapd#106
rgreinho pushed a commit to rgreinho/scrapd that referenced this issue Jun 8, 2019
@anthonybaulo @mergify
Extract deceased field to its own function (scrapd#136)
2fa140e 
* Start branch

* Extract deceased parsing to its own function

The function parse_deceased_field() was created to pull content from the
corresponding field on the fatality page. There was an existing function
of the same name, which has now been renamed process_deceased_field().
Test cases have been made for the new parse_deceased_field().

Fixes scrapd#106

* Add check for deceased field

The deceased field will not be created in the dictionary
unless a match was found.

Fixes scrapd#106
@rgreinho
Copy link
Member Author

rgreinho commented Jun 8, 2019

Closed by #136.

@rgreinho rgreinho closed this as completed Jun 8, 2019
Maintaince mode or second milestone automation moved this from In progress to Done Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/beginner Good for newcomers kind/enhancement Improve an existing feature status/claimed Assigned
Projects
No open projects
Maintaince mode or second milestone
  
Done
Milestone
1.5.2 - Keep the code clean
Development

Successfully merging a pull request may close this issue.

Extract deceased field to its own function anthonybaulo/scrapd
2 participants
@rgreinho @anthonybaulo