Extract deceased field to its own function

[anthonybaulo]

Types of changes

• Code cleanup / Refactoring

Description

Extract deceased field to its own function with tests.
Rename previous parse_deceased_field() to process_deceased_field()

Checklist:

• I have updated the documentation accordingly
• I have written unit tests

Fixes: #106

[anthonybaulo]

@rgreinho
There's a lot going on with parsing the deceased field (L344-470 in apd.py), including a function named parse_deceased_field().
Is this issue solely concerned with extracting a parsing function for use inside of parse_page_content() on L504, which would literally just be moving the existing regex from the searches list into a new function?

searches = [
        (Fields.DECEASED, re.compile(r'>Deceased:\s*(?:</span>)?(?:</strong>)?\s*>?([^<]*\d)\s*.*\)?<')),
        (Fields.LOCATION, re.compile(r'>Location:.*>\s{2,}(?:</strong>)?([^<]+)')),
    ]

If so, what would you like to call the new function, since parse_deceased_field() is being used for something else?

[rgreinho]

Oh you're right! so let's do the following:

• Rename the existing parse_deceased_field() function to process_deceased_field(). Be sure to catch all the references to this functions. VS Code will be your friend :)
• Name the new function you will create parse_deceased_field().

And we should be good to go!

[rgreinho]

Very good job overall! Just one minor comment to check whether or not we succeeded to parse the field before adding it do the results.

[rgreinho]

And merged! Great work @anthonybaulo!