Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_key, _type #104

Closed
manycoding opened this issue Jun 5, 2019 · 1 comment
Closed

_key, _type #104

manycoding opened this issue Jun 5, 2019 · 1 comment
Assignees
@manycoding
Labels
Type: Bug Something isn't working Type: Feature New feature or request
Milestone
0.3.6

Comments

@manycoding
Copy link
Contributor

manycoding commented Jun 5, 2019 •
edited
Loading

  1. Keep it in raw data if it's there
  2. Make dataframe consistent with what Cloud shows - i.e. remove _key and _type.
  3. keep _key in dataframe index if it's present
  4. Remove both fields from schema validation
@manycoding manycoding added the Type: Feature New feature or request label Jun 5, 2019
@manycoding manycoding self-assigned this Jun 5, 2019
@manycoding manycoding mentioned this issue Jun 5, 2019
Closed
@manycoding manycoding added the Type: Bug Something isn't working label Jun 5, 2019
@manycoding
Copy link
Contributor Author

It should also fix the case when raw data doesn't contain _key, which leads to failure of some _key dependent rules.

@manycoding manycoding added this to the 0.3.6 milestone Jun 6, 2019
manycoding added a commit that referenced this issue Jun 7, 2019
@manycoding
Skip _type, _key from schema validation, closes #104
e581d16
@manycoding manycoding mentioned this issue Jun 11, 2019
Merged
manycoding added a commit that referenced this issue Jun 12, 2019
@manycoding
_key and _type (#106)
32927ac 
* Use _key or index for schema errors

* Store _key in dataframe index

* Use index instead of _key in rules

* Drop _type only from cloud items

* Skip _type, _key from schema validation, closes #104

* Refactor validator to func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manycoding manycoding

Labels
Type: Bug Something isn't working Type: Feature New feature or request
Projects
None yet
Milestone
0.3.6
Development

No branches or pull requests
1 participant
@manycoding