Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop _type from dataframe #105

Closed
wants to merge 1 commit into from
Closed

Drop _type from dataframe #105

wants to merge 1 commit into from

Conversation

manycoding
Copy link
Contributor

@manycoding manycoding commented Jun 5, 2019

#104
I doubt that having _type is useful, so I removed it from Items.df
Items.raw is untouched.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #105 into 0.3.6dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.3.6dev   #105      +/-   ##
==========================================
+ Coverage     78.98%    79%   +0.01%     
==========================================
  Files            23     23              
  Lines          1599   1600       +1     
  Branches        280    280              
==========================================
+ Hits           1263   1264       +1     
  Misses          290    290              
  Partials         46     46
Impacted Files Coverage Δ
src/arche/readers/items.py 85.36% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4edd1...b6c94ea. Read the comment docs.

@manycoding
Copy link
Contributor Author

Merged to #106

@manycoding manycoding closed this Jun 6, 2019
@manycoding manycoding deleted the drop_type branch June 6, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant