Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have both field coverage diff and field coverage #51

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

manycoding
Copy link
Contributor

@manycoding manycoding commented Apr 9, 2019

Addressing my concerns in #46 , now we have both coverage and fields with >5% difference in coverage.

import arche
arche.rules.coverage.get_difference(g.source_items.job, g.target_items.job).show()

That's coverage. I don't know about the correct name so I made it as precise as possible - we get this coverage from dividing job stats on total items.
Screenshot 2019-04-09 at 13 22 37
And that's the >5% difference (from substraction of values from the previous graph)
Screenshot 2019-04-09 at 13 23 46

That's how it looks with % tickformat, which is an option, not included in this pr
Screenshot 2019-04-09 at 13 33 31

That's how it looks on unbalanced data (>100% coverage)
Screenshot 2019-04-09 at 13 35 24

@manycoding manycoding changed the base branch from master to result_stats April 9, 2019 17:13
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #51 into result_stats will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff                @@
##           result_stats      #51      +/-   ##
================================================
+ Coverage          62.2%   62.22%   +0.01%     
================================================
  Files                25       25              
  Lines              1585     1591       +6     
  Branches            278      280       +2     
================================================
+ Hits                986      990       +4     
- Misses              573      575       +2     
  Partials             26       26
Impacted Files Coverage Δ
src/arche/report.py 67.3% <0%> (-1.32%) ⬇️
src/arche/rules/coverage.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d126d1...c5e7817. Read the comment docs.

@manycoding manycoding merged commit 22c8123 into result_stats Apr 10, 2019
@manycoding manycoding deleted the combine_coverage_diff branch April 10, 2019 15:47
@manycoding manycoding restored the combine_coverage_diff branch April 10, 2019 15:50
manycoding added a commit that referenced this pull request Apr 10, 2019
@manycoding manycoding deleted the combine_coverage_diff branch April 10, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants