Category coverage diff #52
Conversation
manycoding
requested review from
ivankivanov,
ejulio,
victor-torres,
andyjmc and
nerevaryn
Codecov Report
@@ Coverage Diff @@
## result_stats #52 +/- ##
================================================
+ Coverage 62.2% 62.27% +0.07%
================================================
Files 25 25
Lines 1585 1588 +3
Branches 278 279 +1
================================================
+ Hits 986 989 +3
Misses 573 573
Partials 26 26
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 62.22% 62.27% +0.05%
==========================================
Files 25 25
Lines 1591 1588 -3
Branches 280 279 -1
==========================================
- Hits 990 989 -1
+ Misses 575 573 -2
Partials 26 26
Continue to review full report at Codecov.
|
| cat_difs.name = ( | ||
| f"Coverage difference between {source_key}'s and {target_key}'s {c}" | ||
| ) | ||
| cat_difs = cat_difs[cat_difs > 10] |
There was a problem hiding this comment.
Maybe instead of a hardcoded value there could be a default value and option to be override it.
We have something similar in BVATF:
https://github.com/scrapinghub/bv_qa_automation/wiki/Coverage-Compare-Fields-Limits:
Brand_name - 10%
Description - 15%
Features - 15%
Identifier_add - 5%
There was a problem hiding this comment.
Once anyone asks for that, it could be done.
Same as #51 , but for categories.
arche.rules.category.get_difference(g.source_items.key, g.target_items.key, g.source_items.df, g.target_items.df, ["META_TEMPLATE_NAME", "BIRTH_COUNTRY"]).show()