Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error item links #89

Merged
merged 7 commits into from
May 21, 2019
Merged

Error item links #89

merged 7 commits into from
May 21, 2019

Conversation

manycoding
Copy link
Contributor

@manycoding manycoding commented May 14, 2019

Clickable links were broken in 0.3.5 - href="http://localhost:8888/files/379407/1/52/1990"

I couldn't mock IPython.display.display() to make a really good tests. Any thoughts?

When I mock like this, mocked_display contains only one call from widget.
The bad mock is here - https://github.com/scrapinghub/arche/compare/test_display_html

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #89 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   70.82%   71.04%   +0.21%     
==========================================
  Files          24       24              
  Lines        1587     1592       +5     
  Branches      275      275              
==========================================
+ Hits         1124     1131       +7     
+ Misses        437      436       -1     
+ Partials       26       25       -1
Impacted Files Coverage Δ
src/arche/rules/json_schema.py 100% <ø> (ø) ⬆️
src/arche/report.py 96.59% <100%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2108d4...3ac1177. Read the comment docs.

Copy link

@ejulio ejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you really need to test display.
It seems similar to try to test print or logging.debug.

@manycoding
Copy link
Contributor Author

@ejulio Normally yes, but I don't want to make the same mistake twice.

Copy link

@raphapassini raphapassini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@victor-torres victor-torres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

@manycoding manycoding merged commit a0b72b1 into master May 21, 2019
@manycoding manycoding deleted the error_item_links branch May 21, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants