-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error item links #89
Error item links #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 70.82% 71.04% +0.21%
==========================================
Files 24 24
Lines 1587 1592 +5
Branches 275 275
==========================================
+ Hits 1124 1131 +7
+ Misses 437 436 -1
+ Partials 26 25 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you really need to test display
.
It seems similar to try to test print
or logging.debug
.
@ejulio Normally yes, but I don't want to make the same mistake twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too 👍
Clickable links were broken in 0.3.5 -
href="http://localhost:8888/files/379407/1/52/1990"
I couldn't mock
IPython.display.display()
to make a really good tests. Any thoughts?When I mock like this,
mocked_display
contains only onecall
from widget.The bad mock is here - https://github.com/scrapinghub/arche/compare/test_display_html