Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert index to str #93

Merged
merged 2 commits into from
May 20, 2019
Merged

Convert index to str #93

merged 2 commits into from
May 20, 2019

Conversation

manycoding
Copy link
Contributor

@manycoding manycoding commented May 17, 2019

Plotly doesn't show np.nan values, so I converted y to str. I didn't notice any difference in speed.
Screenshot 2019-05-17 at 18 19 15

Screenshot 2019-05-17 at 18 23 28

1 line bar graphs are quite thick, I haven't figured out how to set a smaller height.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files          24       24           
  Lines        1587     1587           
  Branches      275      275           
=======================================
  Hits         1124     1124           
  Misses        437      437           
  Partials       26       26
Impacted Files Coverage Δ
src/arche/rules/result.py 98.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cdd98...0e61699. Read the comment docs.

@manycoding manycoding merged commit c2108d4 into master May 20, 2019
@manycoding manycoding deleted the empty_nan_graphs branch May 20, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants