Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Bar Enhancer stopped working #138

Closed
begogerber opened this issue May 26, 2015 · 5 comments
Closed

Location Bar Enhancer stopped working #138

begogerber opened this issue May 26, 2015 · 5 comments

Comments

@begogerber
Copy link

Thanks for the handy tool. Unfortunately, it stopped working recently and I don't know when exactly. I've uninstalled the add-on and reinstalled it to no avail. It works in a clean profile not surprisingly. Is there anything I could clean out that might restore functionality?

Peace,

Bego

@tumpio
Copy link
Contributor

tumpio commented Nov 13, 2015

If it works in a clean profile, try to disable your other addons. And report which one is conflicting with Location Bar Enhancer.

@msdsk
Copy link

msdsk commented Nov 13, 2015

I have the same problem; it doesn't work on a new profile. I'm using firefox developer edition (44.0a2)

@tumpio
Copy link
Contributor

tumpio commented Nov 16, 2015

Browser console dump:

10:22:14.500 1447662134500  addons.xpi  WARN    Error loading bootstrap.js for UIEnhancer@girishsharma: SyntaxError: missing variable name (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/tumpio/AppData/Roaming/Mozilla/Firefox/Profiles/pjg26f3e.dev-edition-default/extensions/UIEnhancer@girishsharma.xpi!/bootstrap.js:454:14) JS Stack trace: @XPIProvider.jsm:4325:1 < XPI_loadBootstrapScope@XPIProvider.jsm:4325:7 < XPI_callBootstrapMethod@XPIProvider.jsm:4401:1 < XPI_updateAddonDisabledState@XPIProvider.jsm:4575:1 < AddonWrapper_userDisabledSetter@XPIProvider.jsm:6950:9 < set_userDisabled@extensions.xml:1080:11 < oncommand@about:addons:1:1
10:22:14.500 1447662134500  addons.xpi  WARN    Add-on UIEnhancer@girishsharma is missing bootstrap method startup

And the line bootstrap.js#L454 :

          let (part = document.createElementNS(XUL, "menuitem")) {

Never seen such syntax in JS. Could it be changed to:

          {
            let part = document.createElementNS(XUL, "menuitem");

@tumpio
Copy link
Contributor

tumpio commented Nov 16, 2015

aha.. from the docs, support for non-standard let blocks have been dropped in Gecko 44:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let#let_blocks

I can make a pull request for this.

grssam added a commit that referenced this issue Jan 10, 2016
fix issue #138, stopped working on developer edition (44.0a2)
@grssam
Copy link
Owner

grssam commented Jan 10, 2016

Fixed by #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants