Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #138, stopped working on developer edition (44.0a2) #140

Merged
merged 1 commit into from
Jan 10, 2016

Conversation

tumpio
Copy link
Contributor

@tumpio tumpio commented Nov 16, 2015

See #138

Fixes Location Bar Enhancer to work on the latest developer edition 44.0a2 that dropped support for non-standard let blocks.

@mzso
Copy link

mzso commented Dec 26, 2015

Do you happen to have a build of this fixed version?
The dev is rarely around anymore.

@tumpio
Copy link
Contributor Author

tumpio commented Dec 26, 2015

Go to the patch branch and click the download ZIP link. Then rename the downloaded .zip to .xpi and then install:
https://github.com/tumpio/UIEnhancer/tree/patch-1

@tumpio
Copy link
Contributor Author

tumpio commented Dec 26, 2015

I send email to him, but he never responded. I do not know if he has any plans to merge my pull requests.

@mzso
Copy link

mzso commented Dec 26, 2015

Thanks.
Since the dev seems not to be interested in this addon anymore - you and and tophf fixed the last two total breakages - maybe you guys should just fork it and put in on amo.

@Gitoffthelawn
Copy link

@mzso +1

@tumpio tumpio mentioned this pull request Jan 2, 2016
@gmoises
Copy link

gmoises commented Jan 4, 2016

I tried the instructions; downloaded the ZIP file, renamed it to XPI, but it id not install.
Firefox found it to be apparently corrupt.
clipboard-1

@mzso
Copy link

mzso commented Jan 5, 2016

The folder structure is not right. You need to move the files, folders into the root of the archive.
Or use GitHub Extension Installer

grssam added a commit that referenced this pull request Jan 10, 2016
fix issue #138, stopped working on developer edition (44.0a2)
@grssam grssam merged commit d93c010 into grssam:master Jan 10, 2016
@grssam
Copy link
Owner

grssam commented Jan 10, 2016

Thanks for the PR. I'll get this to AMO asap.

@tumpio
Copy link
Contributor Author

tumpio commented Jan 10, 2016

No problem! It's nice to see you around and good new year! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants