Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward declarations #33

Closed
ScrappyCocco opened this issue Jan 31, 2020 · 0 comments · Fixed by #35
Closed

Forward declarations #33

ScrappyCocco opened this issue Jan 31, 2020 · 0 comments · Fixed by #35
Assignees
@ScrappyCocco
Labels
enhancement New feature or request

Comments

@ScrappyCocco
Copy link
Owner

The engine is starting to have way too many includes, everything (possible) should be moved to forward declaration also for a fast compilation
@ScrappyCocco ScrappyCocco added the enhancement New feature or request label Jan 31, 2020
@ScrappyCocco ScrappyCocco self-assigned this Jan 31, 2020
@ScrappyCocco ScrappyCocco linked a pull request Feb 6, 2020 that will close this issue
Forward declarations #35
Merged
ScrappyCocco added a commit that referenced this issue Feb 6, 2020
@ScrappyCocco
Merge pull request #35 from ScrappyCocco/forward_declarations - Closes #
d3b1411 
#33

Moved includes to use of forward declarations, to reduce include complexity and to have more clean include files. Also removed a few unused includes and fixed a few warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScrappyCocco ScrappyCocco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward declarations ScrappyCocco/ScrapEngine
1 participant
@ScrappyCocco