[MRG +1] remove scrapy deploy command #1102
Closed
+5
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyov
force-pushed
the
nyov/remove-deploy
branch
from
bdbc7b7
to
62aea0c
Compare
nyov
added a commit
to nyov/scrapy
that referenced
this pull request
Mar 24, 2015
nyov
force-pushed
the
nyov/remove-deploy
branch
from
62aea0c
to
1abdce7
Compare
nyov
added a commit
to nyov/scrapy
that referenced
this pull request
Mar 24, 2015
|
Looks good; +1 to merge once we create scrapyd-client package. |
kmike
changed the title
|
Since we merged #1124 I think we can merge this removal now, what do you think? (though it needs to be rebased before that). |
|
+1 but needs rebase |
curita
added a commit
that referenced
this pull request
Apr 20, 2015
|
Rebased and merged in 0bf1ec1 |
curita
pushed a commit
to curita/scrapy
that referenced
this pull request
Apr 21, 2015
|
Thank you! sorry for skipping out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1027
I'm not sure this if is really all there is to it. Basically just trashed the file here.