Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG +1] remove scrapy deploy command #1102

Closed
wants to merge 1 commit into from
Closed

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Mar 24, 2015

For #1027

I'm not sure this if is really all there is to it. Basically just trashed the file here.

@nyov nyov force-pushed the nyov:nyov/remove-deploy branch from bdbc7b7 to 62aea0c Mar 24, 2015
nyov added a commit to nyov/scrapy that referenced this pull request Mar 24, 2015
@nyov nyov force-pushed the nyov:nyov/remove-deploy branch from 62aea0c to 1abdce7 Mar 24, 2015
nyov added a commit to nyov/scrapy that referenced this pull request Mar 24, 2015
@kmike
Copy link
Member

@kmike kmike commented Mar 24, 2015

Looks good; +1 to merge once we create scrapyd-client package.

@kmike kmike changed the title remove scrapy deploy command [MRG +1] remove scrapy deploy command Mar 26, 2015
(closes #1027, #1095, #1102)
@nyov nyov force-pushed the nyov:nyov/remove-deploy branch from 1abdce7 to 550f8f1 Apr 5, 2015
@curita
Copy link
Member

@curita curita commented Apr 10, 2015

Since we merged #1124 I think we can merge this removal now, what do you think? (though it needs to be rebased before that).

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 10, 2015

+1 but needs rebase

curita added a commit that referenced this pull request Apr 20, 2015
curita added a commit that referenced this pull request Apr 20, 2015
@curita
Copy link
Member

@curita curita commented Apr 20, 2015

Rebased and merged in 0bf1ec1

@curita curita closed this Apr 20, 2015
curita added a commit to curita/scrapy that referenced this pull request Apr 21, 2015
@nyov
Copy link
Contributor Author

@nyov nyov commented Apr 27, 2015

Thank you! sorry for skipping out.

@nyov nyov deleted the nyov:nyov/remove-deploy branch Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants