Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sphinx autodoc use local, not system-wide Scrapy #1335

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Make Sphinx autodoc use local, not system-wide Scrapy #1335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d438075
Make Sphinx autodoc use local, not system-wide Scrapy
jdemaeyer Jul 3, 2015
9c12a3f
Remove incorrect path for Sphinx autodoc
jdemaeyer Jul 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
# absolute, like shown here.
sys.path.append(path.join(path.dirname(__file__), "_ext"))
sys.path.append(path.join(path.dirname(path.dirname(__file__)), "scrapy"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm confused what this line is for? Are any Scrapy submodules ever referenced without scrapy. prefixed? Removing it creates no errors on my system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is an error, and the intention was the same as in your PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. In that case I guess it's fine to remove it?

sys.path.insert(0, path.dirname(path.dirname(__file__)))


# General configuration
Expand Down