Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Added possibility to fine-tune logging in CrawlerProcess #2751

Closed
wants to merge 1 commit into from

Conversation

lockie
Copy link

@lockie lockie commented May 19, 2017

Hello!
This little PR adds possibility to overwrite install_root_handler setting for scrapy.utils.log.configure_logging in CrawlerProcess, to remedy a situations like this.

@codecov-io
Copy link

Codecov Report

Merging #2751 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2751   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         163      163           
  Lines        9164     9164           
  Branches     1362     1362           
=======================================
  Hits         7765     7765           
  Misses       1147     1147           
  Partials      252      252
Impacted Files Coverage Δ
scrapy/crawler.py 90% <100%> (ø) ⬆️

@kmike kmike changed the title Added possibility to fine-tune logging in CrawlerProcess [MRG+1] Added possibility to fine-tune logging in CrawlerProcess Sep 28, 2017
@kmike
Copy link
Member

kmike commented Sep 28, 2017

Hey @lockie,

This PR makes sense, but I'm closing it in favor of #2921, as the latter is a tiny bit cleaner.

@kmike kmike closed this Sep 28, 2017
@lockie
Copy link
Author

lockie commented Sep 28, 2017

Ok sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants