[Doc] Update Response.body type #2922
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2922 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 164 164
Lines 9192 9192
Branches 1370 1370
=======================================
Hits 7798 7798
Misses 1138 1138
Partials 256 256 |
docs/topics/request-response.rst
Outdated
| @@ -525,11 +525,11 @@ Response objects | |||
| (for single valued headers) or lists (for multi-valued headers). | |||
| :type headers: dict | |||
|
|
|||
| :param body: the response body. It must be str, not unicode, unless you're | |||
| using a encoding-aware :ref:`Response subclass | |||
| :param body: the response body. To access the decoded text as str you can | |||
kmike
Sep 12, 2017
Member
str is not right in Python 2; what do you think about adding something like "decoded text as str (unicode in Python 2)"?
str is not right in Python 2; what do you think about adding something like "decoded text as str (unicode in Python 2)"?
stav
Sep 12, 2017
Author
Contributor
Python 2? What's that? ha
Sure thing.
Python 2? What's that? ha
Sure thing.
|
Thanks @stav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Noted by
gr3yh47in#scrapyIRC channel.