Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update Response.body type #2922

Merged
merged 1 commit into from Oct 2, 2017
Merged

[Doc] Update Response.body type #2922

merged 1 commit into from Oct 2, 2017

Conversation

stav
Copy link
Contributor

@stav stav commented Sep 12, 2017

Noted by gr3yh47 in #scrapy IRC channel.

@codecov
Copy link

codecov bot commented Sep 12, 2017 •
edited

Codecov Report

Merging #2922 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         164      164           
  Lines        9192     9192           
  Branches     1370     1370           
=======================================
  Hits         7798     7798           
  Misses       1138     1138           
  Partials      256      256

kmike
kmike reviewed Sep 12, 2017
View reviewed changes
docs/topics/request-response.rst Outdated
@@ -525,11 +525,11 @@ Response objects
(for single valued headers) or lists (for multi-valued headers).
:type headers: dict

:param body: the response body. It must be str, not unicode, unless you're
using a encoding-aware :ref:`Response subclass
:param body: the response body. To access the decoded text as str you can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str is not right in Python 2; what do you think about adding something like "decoded text as str (unicode in Python 2)"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2? What's that? ha
Sure thing.

@kmike
Copy link
Member

kmike commented Oct 2, 2017

Thanks @stav!

@kmike kmike merged commit 92fa74f into scrapy:master Oct 2, 2017
@kmike kmike added this to the v1.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stav @kmike