Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update Response.body type #2922

Merged
merged 1 commit into from Oct 2, 2017
Merged

[Doc] Update Response.body type #2922

merged 1 commit into from Oct 2, 2017

Conversation

@stav
Copy link
Contributor

@stav stav commented Sep 12, 2017

Noted by gr3yh47 in #scrapy IRC channel.

@codecov
Copy link

@codecov codecov bot commented Sep 12, 2017

Codecov Report

Merging #2922 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         164      164           
  Lines        9192     9192           
  Branches     1370     1370           
=======================================
  Hits         7798     7798           
  Misses       1138     1138           
  Partials      256      256
@@ -525,11 +525,11 @@ Response objects
(for single valued headers) or lists (for multi-valued headers).
:type headers: dict

:param body: the response body. It must be str, not unicode, unless you're
using a encoding-aware :ref:`Response subclass
:param body: the response body. To access the decoded text as str you can

This comment has been minimized.

@kmike

kmike Sep 12, 2017
Member

str is not right in Python 2; what do you think about adding something like "decoded text as str (unicode in Python 2)"?

This comment has been minimized.

@stav

stav Sep 12, 2017
Author Contributor

Python 2? What's that? ha
Sure thing.

@kmike
Copy link
Member

@kmike kmike commented Oct 2, 2017

Thanks @stav!

@kmike kmike merged commit 92fa74f into scrapy:master Oct 2, 2017
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing b8fabee...3637b75
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike added this to the v1.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants