Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated contributing.rst #3127

Merged
merged 2 commits into from Feb 16, 2018
Merged

Updated contributing.rst #3127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6954da1
Updated contributing.rst
Anjalizi Feb 15, 2018
bbc2a35
further edited
Anjalizi Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/contributing.rst
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ Contributing to Scrapy

.. important::

Double check you are reading the most recent version of this document at
Double check that you are reading the most recent version of this document at
https://doc.scrapy.org/en/master/contributing.html

There are many ways to contribute to Scrapy. Here are some of them:
Expand All @@ -18,7 +18,7 @@ There are many ways to contribute to Scrapy. Here are some of them:
* Report bugs and request features in the `issue tracker`_, trying to follow
the guidelines detailed in `Reporting bugs`_ below.

* Submit patches for new functionality and/or bug fixes. Please read
* Submit patches for new functionalities and/or bug fixes. Please read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker, but https://english.stackexchange.com/questions/196590/functionality-vs-functionalities-are-both-correct-and-idiomatic seems to suggest "functionality" is ok here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, either is fine I think. :)

:ref:`writing-patches` and `Submitting patches`_ below for details on how to
write and submit a patch.

Expand Down Expand Up @@ -80,8 +80,8 @@ guidelines when reporting a new bug.
Writing patches
===============

The better written a patch is, the higher chance that it'll get accepted and
the sooner that will be merged.
The better written a patch is, higher is the chance that it'll get accepted and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line wasn't, and isn't, very idiomatic English. I would rephrase as "The better a patch is written, the higher the chances that it'll get accepted, and the sooner it will be merged".

sooner it will be merged.

Well-written patches should:

Expand Down