[MRG+1] Add 'flv' to ignored video extensions. #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
requested changes
Mar 12, 2018
scrapy/linkextractors/__init__.py
Outdated
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| # video | |||
| '3gp', 'asf', 'asx', 'avi', 'mov', 'mp4', 'mpg', 'qt', 'rm', 'swf', 'wmv', | |||
| 'm4a', 'm4v', | |||
| 'm4a', 'm4v', 'flv' | |||
There was a problem hiding this comment.
Comma is missing. You've replaced "xls" with "flvxls" in this PR: Python joins strings with no separators between them.
There was a problem hiding this comment.
Ah, sorry. Added comma.
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 228 228
Lines 9588 9588
Branches 1385 1385
=======================================
Hits 7873 7873
Misses 1456 1456
Partials 259 259
|
kmike
changed the title
kmike
approved these changes
Mar 12, 2018
|
Thanks @siulkilulki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flv extension is missing. I run into downloading large .flv file while scraping.