Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add 'flv' to ignored video extensions. #3165

Merged
merged 2 commits into from Mar 13, 2018

Conversation

@siulkilulki
Copy link
Contributor

@siulkilulki siulkilulki commented Mar 11, 2018

flv extension is missing. I run into downloading large .flv file while scraping.

Copy link
Member

@kmike kmike left a comment

+1 to add flv extension to the list.

@@ -28,7 +28,7 @@

# video
'3gp', 'asf', 'asx', 'avi', 'mov', 'mp4', 'mpg', 'qt', 'rm', 'swf', 'wmv',
'm4a', 'm4v',
'm4a', 'm4v', 'flv'

This comment has been minimized.

@kmike

kmike Mar 12, 2018
Member

Comma is missing. You've replaced "xls" with "flvxls" in this PR: Python joins strings with no separators between them.

This comment has been minimized.

@siulkilulki

siulkilulki Mar 12, 2018
Author Contributor

Ah, sorry. Added comma.

@codecov
Copy link

@codecov codecov bot commented Mar 12, 2018

Codecov Report

Merging #3165 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3165   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         228      228           
  Lines        9588     9588           
  Branches     1385     1385           
=======================================
  Hits         7873     7873           
  Misses       1456     1456           
  Partials      259      259
Impacted Files Coverage Δ
scrapy/linkextractors/__init__.py 100% <ø> (ø) ⬆️
@kmike kmike changed the title Add 'flv' to ignored video extensions. [MRG+1] Add 'flv' to ignored video extensions. Mar 12, 2018
@kmike
kmike approved these changes Mar 12, 2018
@lopuhin lopuhin merged commit 6a7cdf9 into scrapy:master Mar 13, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing acd2b8d...7471bc3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 13, 2018

Thanks @siulkilulki !

@kmike kmike added this to the v1.6 milestone Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants