Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.7 support #3326

Merged
merged 14 commits into from
Jul 11, 2018
Merged

Python 3.7 support #3326

merged 14 commits into from
Jul 11, 2018

Commits on Mar 2, 2018

  1. [WIP] Run tests for Python 3.7

    @patiences
    patiences committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    aca2655 View commit details
    Browse the repository at this point in the history

  2. Use 3.7-dev version for travis

    @patiences
    patiences committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    fab68ff View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Install Twisted from branch to bypass syntax issue

    @patiences
    patiences committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    ca7d79c View commit details
    Browse the repository at this point in the history

  2. [WIP] Install Twisted from branch to bypass syntax issue

    @patiences
    patiences committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    5d1f524 View commit details
    Browse the repository at this point in the history

  3. [WIP] Install Twisted from branch for py3.7

    @patiences
    patiences committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    f10a43d View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Merge branch 'master' of https://github.com/patiences/scrapy into pat… 

    …iences-master
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    1d2e273 View commit details
    Browse the repository at this point in the history

  2. Update ancient pytest on python 3 

    2.9 gives collection errors on python 3.7 due to PEP 479.
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    722e1af View commit details
    Browse the repository at this point in the history

  3. Catch SyntaxError as well when importing manhole 

    Also give a more detailed reason why telnet is not enabled (for the
future).
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    17e9914 View commit details
    Browse the repository at this point in the history

  4. Use python 3.7 on travis

    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    cf9399a View commit details
    Browse the repository at this point in the history

  5. Make "docs" the last build, even though it still uses python3.6 for now

    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    2773fe0 View commit details
    Browse the repository at this point in the history

  6. Make csviter work on python 3.7 

    PEP 479 does not allow for StopIteration in generators.  Instead,
handle it explicitly, also use a for loop which looks simpler.
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    f4f3905 View commit details
    Browse the repository at this point in the history

  7. Try to get python3.7 by using xenial base and sudo 

    See travis-ci/travis-ci#9815 (comment)
and travis-ci/travis-ci#9815 (comment)
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    b3cd12d View commit details
    Browse the repository at this point in the history

  8. Fix telnet warnings in tests 

    Disable telnet console if it's not available, else we'll get an extra
warning about failure to enable it, and tests will fail.
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    92b504e View commit details
    Browse the repository at this point in the history

  9. More visible telnet conch message 

    Capture traceback when trying to import required twisted modules,
print it in case telnet is enabled, and mention settings variable
that can be used to supress the message.
Thanks @kmike!
    @lopuhin
    lopuhin committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    9428a4a View commit details
    Browse the repository at this point in the history