Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused imports from scrapy/settings/__init__.py #3359

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

kmike
Copy link
Member

@kmike kmike commented Jul 31, 2018

This is a follow-up to #3327.

@kmike kmike added this to the v1.6 milestone Jul 31, 2018
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #3359 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
+ Coverage   84.34%   84.35%   +<.01%     
==========================================
  Files         167      167              
  Lines        9359     9357       -2     
  Branches     1388     1388              
==========================================
- Hits         7894     7893       -1     
  Misses       1209     1209              
+ Partials      256      255       -1
Impacted Files Coverage Δ
scrapy/settings/__init__.py 92.98% <ø> (-0.09%) ⬇️
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

@lopuhin lopuhin merged commit eb007ba into master Aug 2, 2018
@lopuhin
Copy link
Member

lopuhin commented Aug 2, 2018

Thanks @kmike !

@lopuhin lopuhin deleted the unused-imports branch August 2, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants