Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix contract errback (#3370) #3371

Merged
merged 1 commit into from Aug 10, 2018
Merged

Conversation

@StasDeep
Copy link
Contributor

@StasDeep StasDeep commented Aug 9, 2018

Fix an AttributeError which was raised in Python 3 due to incorrect order of exc_info components.

Fixes #3370.

@kmike kmike changed the title Fix contract errback (#3370) [MRG+1] Fix contract errback (#3370) Aug 9, 2018
@kmike
Copy link
Member

@kmike kmike commented Aug 9, 2018

A good catch 👍
It is also a bug in Python 2, right?

@kmike kmike added this to the v1.6 milestone Aug 9, 2018
@StasDeep
Copy link
Contributor Author

@StasDeep StasDeep commented Aug 9, 2018

@kmike nope, looked like it only occurred in Python 3 (because of different implementation of TestResult._exc_info_to_string method).

@codecov
Copy link

@codecov codecov bot commented Aug 9, 2018

Codecov Report

Merging #3371 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
+ Coverage   84.36%   84.39%   +0.03%     
==========================================
  Files         167      167              
  Lines        9361     9361              
  Branches     1390     1390              
==========================================
+ Hits         7897     7900       +3     
+ Misses       1209     1206       -3     
  Partials      255      255
Impacted Files Coverage Δ
scrapy/contracts/__init__.py 70.53% <100%> (+2.67%) ⬆️
@StasDeep
Copy link
Contributor Author

@StasDeep StasDeep commented Aug 10, 2018

@kmike are we waiting for someone else to review this PR?

@lopuhin lopuhin merged commit 8a4e51a into scrapy:master Aug 10, 2018
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 84.36%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lopuhin
Copy link
Member

@lopuhin lopuhin commented Aug 10, 2018

Thanks @StasDeep, great catch !

are we waiting for someone else to review this PR?

Yes, usually the policy is to have two people review the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants