[MRG+1] Fix contract errback (#3370) #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
changed the title
|
A good catch 👍 |
|
@kmike nope, looked like it only occurred in Python 3 (because of different implementation of |
Codecov Report
@@ Coverage Diff @@
## master #3371 +/- ##
==========================================
+ Coverage 84.36% 84.39% +0.03%
==========================================
Files 167 167
Lines 9361 9361
Branches 1390 1390
==========================================
+ Hits 7897 7900 +3
+ Misses 1209 1206 -3
Partials 255 255
|
|
@kmike are we waiting for someone else to review this PR? |
|
Thanks @StasDeep, great catch !
Yes, usually the policy is to have two people review the PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an
AttributeErrorwhich was raised in Python 3 due to incorrect order ofexc_infocomponents.Fixes #3370.