Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] add FEED_STORAGE_S3_ACL setting #3607

Merged
merged 21 commits into from
Mar 22, 2019
Merged

[MRG+1] add FEED_STORAGE_S3_ACL setting #3607

merged 21 commits into from
Mar 22, 2019

Commits on Feb 8, 2019

  1. add FEED_STORAGE_S3_ACL setting

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    0135680 View commit details
    Browse the repository at this point in the history

  2. refactoring

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    ad83ffd View commit details
    Browse the repository at this point in the history

  3. PEP8: use short name for mock method

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    126207f View commit details
    Browse the repository at this point in the history

  4. update docs

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    e0f34be View commit details
    Browse the repository at this point in the history

  5. remove typo

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    7b83ed7 View commit details
    Browse the repository at this point in the history

  6. calling it feeds instead of objects

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    e25b9a2 View commit details
    Browse the repository at this point in the history

  7. trying to fix jessie testenv by adding botocore to requirements and f… 

    …ixing its version
    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    dbeb088 View commit details
    Browse the repository at this point in the history

  8. also testing without botocore

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    079af88 View commit details
    Browse the repository at this point in the history

  9. add FEED_STORAGE_S3_ACL to default_settings.py file

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    ceae356 View commit details
    Browse the repository at this point in the history

  10. no need to use get here since we're defining a default value in defau… 

    …lt_settings.py
    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    cfd183a View commit details
    Browse the repository at this point in the history

  11. testing public method store instead of private method _store_in_thread 

    need to mock deferToThread function
    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    f824f5b View commit details
    Browse the repository at this point in the history

  12. simplifying how we deal with threads.deferToThread calls

    @victor-torres
    victor-torres committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    1eac2a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. using named params with optional amazon s3 params

    @victor-torres
    victor-torres committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    7c9f0bd View commit details
    Browse the repository at this point in the history

  2. reduce code with simple ternary operator

    @victor-torres
    victor-torres committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    c2dede2 View commit details
    Browse the repository at this point in the history

  3. using blank string instead of None as default value as proposed by @k… 

    …mike
    @victor-torres
    victor-torres committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    984e706 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. setting botocore version as described in debian jessie website 

    https://packages.debian.org/en/jessie/python-botocore
    @victor-torres
    victor-torres committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    b4d132b View commit details
    Browse the repository at this point in the history

  2. refactoring tests to avoid mocking private method

    @victor-torres
    victor-torres committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    dc0b643 View commit details
    Browse the repository at this point in the history

  3. botocore is not supported on debian jessie

    @victor-torres
    victor-torres committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    ea8be62 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. try to import botocore before runing some tests

    @victor-torres
    victor-torres committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9b8ba4c View commit details
    Browse the repository at this point in the history

  2. trigger tests

    @victor-torres
    victor-torres committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9fed6fc View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into feed-storage-s3-acl

    @victor-torres
    victor-torres committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    fda1d04 View commit details
    Browse the repository at this point in the history