Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] rel_has_nofollow: remove redundant if statement #3629

Merged
merged 1 commit into from Mar 15, 2019
Merged

[MRG+1] rel_has_nofollow: remove redundant if statement #3629

merged 1 commit into from Mar 15, 2019

Conversation

@johndela1
Copy link
Contributor

@johndela1 johndela1 commented Feb 16, 2019

no need for if because expression already returns bool

@codecov
Copy link

@codecov codecov bot commented Feb 16, 2019

Codecov Report

Merging #3629 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3629      +/-   ##
==========================================
+ Coverage   84.52%   84.53%   +<.01%     
==========================================
  Files         167      167              
  Lines        9410     9408       -2     
  Branches     1397     1397              
==========================================
- Hits         7954     7953       -1     
+ Misses       1199     1198       -1     
  Partials      257      257
Impacted Files Coverage Δ
scrapy/cmdline.py 67.66% <0%> (+0.26%) ⬆️
scrapy/utils/misc.py 95.71% <100%> (ø) ⬆️
scrapy/pipelines/images.py 90.71% <100%> (ø) ⬆️

ejulio
ejulio approved these changes Feb 19, 2019
Copy link
Contributor

@ejulio ejulio left a comment

👌

@kmike kmike changed the title rel_has_nofollow: remove redundant if statement [MRG+1] rel_has_nofollow: remove redundant if statement Mar 14, 2019
@kmike
Copy link
Member

@kmike kmike commented Mar 14, 2019

Thanks for the cleanup @johndela1, and thanks @ejulio for checking it.

@Gallaecio Gallaecio merged commit 2bd5790 into scrapy:master Mar 15, 2019
3 checks passed
@kmike kmike added this to the v1.7 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants