Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spiderloader): no duplicate spider names #4560

Merged
merged 1 commit into from May 12, 2020

Conversation

adityaa30
Copy link
Contributor

@adityaa30 adityaa30 commented May 10, 2020

Removal of Line-31 in 4c12a23 do not fail the tests. If we update the tests to check that

  1. The number of occurence in the warning should be 2
  2. Spider classes not having duplicate names do not show in warning

The tests will fail for 4c12a23

Fixes #4549

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #4560 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4560   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         164      164           
  Lines        9908     9908           
  Branches     1475     1475           
=======================================
  Hits         8376     8376           
  Misses       1266     1266           
  Partials      266      266           

Copy link
Member

@Gallaecio Gallaecio left a comment

Verified locally, great work!

@Gallaecio Gallaecio merged commit 97532a9 into scrapy:master May 12, 2020
2 checks passed
@adityaa30 adityaa30 deleted the test-spiderloader branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants