Use ItemAdapter.field_names when writing header in CsvItemExporter #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4668 +/- ##
==========================================
- Coverage 86.29% 86.29% -0.01%
==========================================
Files 160 160
Lines 9646 9644 -2
Branches 1416 1415 -1
==========================================
- Hits 8324 8322 -2
Misses 1062 1062
Partials 260 260
|
Gallaecio
approved these changes
Jul 11, 2020
elacuesta
force-pushed
the
fix-exporters-dataclass-csv-header
branch
from
72eed18
to
f354d1e
Compare
elacuesta
force-pushed
the
fix-exporters-dataclass-csv-header
branch
from
f354d1e
to
c29e687
Compare
wRAR
approved these changes
Jul 22, 2020
Gallaecio
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4667
Missing tests, I'll add them shortlyTests were added.