Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ItemAdapter.field_names when writing header in CsvItemExporter #4668

Merged
merged 3 commits into from Jul 28, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 8, 2020

Fixes #4667

Missing tests, I'll add them shortly Tests were added.

@elacuesta elacuesta added this to the v2.2.1 milestone Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #4668 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4668      +/-   ##
==========================================
- Coverage   86.29%   86.29%   -0.01%     
==========================================
  Files         160      160              
  Lines        9646     9644       -2     
  Branches     1416     1415       -1     
==========================================
- Hits         8324     8322       -2     
  Misses       1062     1062              
  Partials      260      260              
Impacted Files Coverage Δ
scrapy/exporters.py 100.00% <100.00%> (ø)

@elacuesta elacuesta force-pushed the fix-exporters-dataclass-csv-header branch from 72eed18 to f354d1e Compare Jul 21, 2020
@elacuesta elacuesta force-pushed the fix-exporters-dataclass-csv-header branch from f354d1e to c29e687 Compare Jul 21, 2020
@elacuesta elacuesta marked this pull request as ready for review Jul 21, 2020
wRAR
wRAR approved these changes Jul 22, 2020
@wRAR wRAR requested a review from Gallaecio Jul 22, 2020
@kmike kmike modified the milestones: v2.2.1, v2.3 Jul 23, 2020
@Gallaecio Gallaecio merged commit 5265853 into scrapy:master Jul 28, 2020
2 checks passed
@elacuesta elacuesta deleted the fix-exporters-dataclass-csv-header branch Jul 28, 2020
@elacuesta elacuesta restored the fix-exporters-dataclass-csv-header branch Oct 1, 2021
@elacuesta elacuesta deleted the fix-exporters-dataclass-csv-header branch Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of fields incorrectly accessed for dataclass items
4 participants