-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Added zsh completion for Scrapy command-line tool and updated bash completion #934
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d0ea5a
Added zsh completion for the Scrapy command-line tool
Dineshs91 e2b4fab
Fix zsh completion path
Dineshs91 7129dc3
Move scrapy_zsh_completion inside extras directory
Dineshs91 843a9cd
Remove deploy command from arguments
Dineshs91 b124735
Remove server command
Dineshs91 d55ae53
Remove deploy and server commands from bash completion
Dineshs91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
extras/scrapy_bash_completion etc/bash_completion.d/ | ||
extras/scrapy_zsh_completion /usr/share/zsh/vendor-completions/_scrapy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#compdef scrapy | ||
|
||
# zsh completion for the Scrapy command-line tool | ||
|
||
_scrapy() { | ||
local curcontext="$curcontext" cmd spiders | ||
typeset -A opt_args | ||
cmd=$words[2] | ||
|
||
case "$cmd" in | ||
crawl|edit|check) | ||
spiders=$(scrapy list 2>/dev/null) || spiders="" | ||
if [[ -n "$spiders" ]]; then | ||
compadd `echo $spiders` | ||
fi | ||
;; | ||
*) | ||
if [[ CURRENT -eq 2 ]]; then | ||
_arguments '*: :(check crawl deploy edit fetch genspider list parse runspider server settings shell startproject version view)' | ||
fi | ||
;; | ||
esac | ||
} | ||
|
||
_scrapy |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are removing 'scrapy deploy' command, I think it shouldn't be listed here