Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh-1159: Add 2017 to Teacher Registration #1160

Merged
merged 2 commits into from
Jan 31, 2017
Merged

Fix gh-1159: Add 2017 to Teacher Registration #1160

merged 2 commits into from
Jan 31, 2017

Conversation

TheGrits
Copy link
Contributor

Should fix #1159

Test cases:

  • 2017 should now be an option
  • 1916 should no longer be an option

rschamp
rschamp suggested changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I have a request to future-proof this.

src/components/registration/steps.jsx Outdated
@@ -324,7 +324,7 @@ module.exports = {
},
getYearOptions: function () {
return Array.apply(null, Array(100)).map(function (v, id) {
var year = 2016 - id;
var year = 2017 - id;

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@rschamp rschamp added this to the February 16 milestone Jan 31, 2017
@rschamp rschamp merged commit 624bdde into scratchfoundation:develop Jan 31, 2017
@rschamp
Copy link
Contributor

rschamp commented Jan 31, 2017

Thanks @TheGrits!

@TheGrits TheGrits deleted the patch-3 branch January 31, 2017 16:09
@TheGrits
Copy link
Contributor Author

@rschamp Anytime!

mewtaylor pushed a commit that referenced this pull request Feb 1, 2017
@rschamp @mewtaylor
Merge pull request #1160 from TheGrits/patch-3
22802f8 
Fix gh-1159: Add 2017 to Teacher Registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschamp rschamp rschamp approved these changes

Assignees
No one assigned
Labels
pr - good to merge
Projects
None yet
Milestone
February 15
Development

Successfully merging this pull request may close these issues.

There's no 2017 in the teacher registration dropdown menu for birth year
2 participants
@TheGrits @rschamp