Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's no 2017 in the teacher registration dropdown menu for birth year #1159

Closed
jwzimmer-zz opened this issue Jan 30, 2017 · 0 comments · Fixed by #1160
Closed

There's no 2017 in the teacher registration dropdown menu for birth year #1159

jwzimmer-zz opened this issue Jan 30, 2017 · 0 comments · Fixed by #1160
Labels
teacher-accounts

Comments

@jwzimmer-zz
Copy link
Contributor

jwzimmer-zz commented Jan 30, 2017 •
edited
Loading

TL;DR: We have 2017 as an option for scratchers signing up from the homepage, but not for teachers. We should be consistent.

If you look at the dropdown from the homepage versus from /educators/register, the year 2017 is not included in the latter:
screen shot 2017-01-30 at 4 52 22 pm

Found while testing https://github.com/LLK/scratchr2/pull/4448, but definitely not a blocker.
TheGrits added a commit to TheGrits/scratch-www that referenced this issue Jan 31, 2017
@TheGrits
Add 2017
d19d084 
Resolves scratchfoundation#1159
@TheGrits TheGrits mentioned this issue Jan 31, 2017
Merged
rschamp added a commit that referenced this issue Jan 31, 2017
@rschamp
Merge pull request #1160 from TheGrits/patch-3
624bdde 
Fix gh-1159: Add 2017 to Teacher Registration
mewtaylor pushed a commit that referenced this issue Feb 1, 2017
@rschamp @mewtaylor
Merge pull request #1160 from TheGrits/patch-3
22802f8 
Fix gh-1159: Add 2017 to Teacher Registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
teacher-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gh-1159: Add 2017 to Teacher Registration TheGrits/scratch-www
1 participant
@jwzimmer-zz