-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard Credentials File #8
Conversation
As a side thought, most screeps utilities have other options along side the connection, for example, screeps console has servers:
...
configs:
screepsconsole:
max_history: 20000
max_scroll: 20000
screepsplus-agent:
token: sptoken
checkForUpdates: false |
Updated `connections` to `servers` Added XDG path to valid paths Added optional configs section
As I mentioned to @ags131 in slack, I propose something more along the lines of
|
IMO, any where the env variable isn't set should be skipped in implementations. Thus the default ( |
@ags131 if you think this is ready to merge lets go ahead and do it. |
Well, my only thing is that the spec for xdg says to use |
Yeah, the xdg spec does have a default for if the environmental variable is set, so it does make sense to fall back on that. I think the clearest way to do that would be to explicitly add the default xdg location to the list (after the one where the environmental variable is set)-
|
Thats easy enough to add, For windows, should these paths still be checked or just skipped? ( |
Well, I guess xdg doesn't make sense on Windows though. |
I'm fine implementing that as just if !Windows, add XDG paths |
LGTM to merge. @Jomik, any other concerns before merging? (We can always open other PRs later to discuss changes too :) ) |
I'm happy with it for my uses 😁 |
This PR adds a standard credentials file to be used by third party applications.