Warning about using Steam client with gulp #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the gulp file watcher
rickpelletier
force-pushed
the
steam-client-warning
branch
from
51292df
to
8d168df
Compare
|
This is a very unusual case, I don't think it should have a dedicated warning (waiting for the opinion of other people to decide what to do) |
|
Maybe have the gulpfile detect if it's being run from the steam directory? |
Yeah good idea, it's quite easy to do |
|
I agree with @valerian on this, this doesn't see the need of a dedicated warning, since a case where people would run this script from the Steam directory would be very minimal. A better mitigation strategy would be to have the gulpfile detect the Steam directory and prevent the tasks from running (as per @Dessix). I will be closing this and create an issue thread for it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😢 Don't waste an entire afternoon trying to figure out why your project has lots of .js files and your gulpfile.js keeps getting deleted.
Resolves #14...