Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packageSourceCredentials when interacting with feeds #1018

Closed
aarondandy opened this issue Apr 9, 2015 · 5 comments
Closed

Use packageSourceCredentials when interacting with feeds #1018

aarondandy opened this issue Apr 9, 2015 · 5 comments

Comments

@aarondandy
Copy link
Contributor

While scriptcs -I does check other feeds for packages that are listed in my NuGet.Config it does not send any credentials in the requests that are found in the packageSourceCredentials element.

@glennblock
Copy link
Contributor

Good catch. With nuget supporting secure repos we should. Wanna take this?
On Thu, Apr 9, 2015 at 11:20 AM Aaron Dandy notifications@github.com
wrote:

While scriptcs -I does check other feeds for packages that are listed in
my NuGet.Config it does not send any credentials in the requests that are
found in the packageSourceCredentials element.


Reply to this email directly or view it on GitHub
#1018.

@aarondandy
Copy link
Contributor Author

It looks like Chocolatey is "Doing It Right" so I may investigate how they do it first. I'll look into it a bit more before I commit to doing it as I really don't know enough about NuGet yet. This is important enough for me that I will probably end up learning more about NuGet though and obviously I have some feeds that require authentication that I can work with.

@glennblock
Copy link
Contributor

Fabulous! :-)
On Thu, Apr 9, 2015 at 11:33 AM Aaron Dandy notifications@github.com
wrote:

It looks like Chocolatey is "Doing It Right" so I may investigate how they
do it first. I'll look into it a bit more before I commit to doing it as I
really don't know enough about NuGet yet. This is important enough for me
that I will probably end up learning more about NuGet though and obviously
I have some feeds that require authentication that I can work with.


Reply to this email directly or view it on GitHub
#1018 (comment).

@aarondandy
Copy link
Contributor Author

I have a fork and am looking into this.

I was wrong about Chocolatey doing it right, those calls I was watching in Fiddler were directly from nuget.exe .

@filipw
Copy link
Member

filipw commented Aug 17, 2018

This was fixed in 0.17.0

@filipw filipw closed this as completed Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants