Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to choose which version of Visual studio to launch, and it defaults to 2013 which doesn't support syntax highlighting #1164

Open
samholder opened this issue Jun 10, 2016 · 10 comments
Assignees

Comments

@samholder
Copy link

When I use the convenience method :openvs "MyScript.csx" the created solution is 2013 format. This means the visual studio version selector uses 2013 to open the project if it is installed, and this does not support syntax highlighting, resulting in a much poorer experience.

It would be nice to either default to 2015 or allow a way to choose 2015 as the version to open

@glennblock
Copy link
Contributor

Thanks @samholder, working on it now.

@glennblock glennblock self-assigned this Jun 10, 2016
@samholder
Copy link
Author

@glennblock only just had time to test this. I rebuilt your master branch in VS and tried to launch scriptcs from the built directory, but when I did :`openvs "MyScript.csx" "2015" I just get

:openvs "MyScript.csx" "2015"
(1,1): error CS7017: Member definition, statement, or end-of-file expected

I'm not sure if its to do with how I launched it, but I tried replacing the chocolatey version with the binaries from the VS build and get the same error, even if I leave out the "2015" bit

@glennblock
Copy link
Contributor

You are getting this in the REPL?

On Wed, Jun 15, 2016 at 5:40 AM Sam Holder notifications@github.com wrote:

@glennblock https://github.com/glennblock only just had time to test
this. I rebuilt your master branch in VS and tried to launch scriptcs from
the built directory, but when I did :`openvs "MyScript.csx" "2015" I just
get

:openvs "MyScript.csx" "2015"
(1,1): error CS7017: Member definition, statement, or end-of-file expected

I'm not sure if its to do with how I launched it, but I tried replacing
the chocolatey version with the binaries from the VS build and get the same
error, even if I leave out the "2015" bit


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1164 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAInRAB8ziaiRb83H_fdq0yJO-9b-nDPks5qL_KjgaJpZM4Iy1MX
.

@samholder
Copy link
Author

yep

@glennblock
Copy link
Contributor

Can you try running from a different folder than the bin folder i.e. Go to
the folder where your script lives and the run scriptcs using relative path?

Alternatively install svm and you can then use svm install -f to bind
directly to that folder.

On Wed, Jun 15, 2016 at 7:28 AM Sam Holder notifications@github.com wrote:

yep


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1164 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAInRDAEelxAMLavQ8eCBeNIR_UIHTlKks5qMAwfgaJpZM4Iy1MX
.

@samholder
Copy link
Author

yeah I did that (I assumed that otherwise it wouldn't find myscript.csx) but with an absolute path (ie I went to my script folder, then c:\path\to\the\bin\folder\scrptcs.exe then :openvs "MyScript.csx" "2015"

I'll have another try tonight if I can make a few minutes

@glennblock
Copy link
Contributor

I'll test it again as well. Thanks!

On Wed, Jun 15, 2016 at 8:36 AM Sam Holder notifications@github.com wrote:

yeah I did that (I assumed that otherwise it wouldn't find myscript.csx)
but with an absolute path (ie I went to my script folder, then
c:\path\to\the\bin\folder\scrptcs.exe then :openvs "MyScript.csx" "2015"

I'll have another try tonight if I can make a few minutes


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1164 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAInRJbMUT4O0ma0Tg1GzSUwvlnU5vL3ks5qMBvlgaJpZM4Iy1MX
.

@samholder
Copy link
Author

I tried this again today and it might be because my script uses 'dynamic'. This works ok with the chocolatey version, but with the version from your branch if I try and run from VS setting a script to be started in command line args it fails with a message about dynamic not being supported in this version of rosylin.

Not sure if thats related to the other issue though as even with a simple script that works when I run the program from VS with it as an argument creates the same issue in the repl launched from hitting F5 in VS

@glennblock
Copy link
Contributor

@samholder you said you rebuilt my master branch? It should have been my dev branch. Can you try again using the latest dev branch in the scriptcs/scriptcs repo?

@samholder
Copy link
Author

ok, I'll try and make some time to test this at some point this week. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants