Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown comments #218

Closed
wants to merge 2 commits into from
Closed

Conversation

kroq-gar78
Copy link
Contributor

The current Markdown comment, >, does not work in the pandoc implementation of Markdown. I am not aware of any implementation of Markdown that uses the > character as a comment symbol, especially since it is used by some implementations for quotation blocks, which is a completely different function (at least, I couldn't find any). Thus, the proposed implementation would work in at least some implementations.

Works at least with pandoc. The older version (the character '>') did not work in pandoc.
alerque added a commit to alerque/nerdcommenter that referenced this pull request May 23, 2016
@alerque
Copy link
Member

alerque commented May 23, 2016

Fork notice: With the upstream project sitting stale after nearly 8 months since the last activity, 71 outstanding pull requests, no comments from the original developer, and dozens of developers duplicating efforts while scratching their own itches, I've decided to step in and run a fork for a while. Hopefully the original developer will eventually consider picking this plugin up again or adding more maintainers so that the user base doesn't end up fragmented, but for now I would invite anyone interested in the latest updates to consider installing from and contributing pull requests to my fork.

About this PR: I have merged this PR as is. Please consider installing the plugin from alerque/nerdcommenter for this and (so far) over two dozen other updates.

Just a small note @kroq-gar78, next time please consider rebasing instead of merging upstream changes before submitting pull requests as that makes it a lot easier to review and keeps the resulting history cleaner.

@alerque alerque closed this in f129cd8 May 23, 2016
@alerque
Copy link
Member

alerque commented May 23, 2016

Change of plans. Thanks to scrooloose who has added me as a maintainer to this repo, I'll be going through and taking care of business here instead of in a fork. I've cherry picked the main commit out of this PR branch and pushed it upstream. The other commit is obsolete.

Thanks for your contribution @kroq-gar78.

@aemonge
Copy link
Contributor

aemonge commented May 25, 2018

Let me suggest a better comment for markdown..... i've research and it seams to be THE one :)

Hope it helps!

#333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants