Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Commit

Permalink
Remove the rustc checket for Rust.
Browse files Browse the repository at this point in the history 
Between #947, #1114, and #1112, this checker is too controversial to
maintain in syntastic.  Please consider using it as an external checker
if you need it:

https://github.com/scrooloose/syntastic/wiki/Syntax-Checker-Guide#external
  • Loading branch information
@lcd047
lcd047 committed Jun 12, 2014
1 parent c333031 commit 1383c0f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 48 deletions.
8 changes: 4 additions & 4 deletions README.markdown
View file
Expand Up @@ -41,10 +41,10 @@ Elixir, Erlang, eRuby, Fortran, Gentoo metadata, GLSL, Go, Haml, Haskell, Haxe,
Handlebars, HSS, HTML, Java, JavaScript, JSON, JSX, LESS, Lex, Limbo, LISP,
LLVM intermediate language, Lua, MATLAB, NASM, Objective-C, Objective-C++,
OCaml, Perl, Perl POD, PHP, gettext Portable Object, OS X and iOS property
lists, Puppet, Python, Racket, R, reStructuredText, Ruby, Rust, SASS/SCSS,
Scala, Slim, Tcl, TeX, Texinfo, Twig, TypeScript, Vala, Verilog, VHDL, VimL,
xHtml, XML, XSLT, YACC, YAML, z80, Zope page templates, and zsh. See the
[wiki][3] for details about the corresponding supported checkers.
lists, Puppet, Python, Racket, R, reStructuredText, Ruby, SASS/SCSS, Scala,
Slim, Tcl, TeX, Texinfo, Twig, TypeScript, Vala, Verilog, VHDL, VimL, xHtml,
XML, XSLT, YACC, YAML, z80, Zope page templates, and zsh. See the [wiki][3]
for details about the corresponding supported checkers.

Below is a screenshot showing the methods that Syntastic uses to display syntax
errors. Note that, in practise, you will only have a subset of these methods
Expand Down
2 changes: 1 addition & 1 deletion plugin/syntastic.vim
View file
Expand Up @@ -19,7 +19,7 @@ if has('reltime')
lockvar! g:syntastic_start
endif

let g:syntastic_version = '3.4.0-83'
let g:syntastic_version = '3.4.0-84'
lockvar g:syntastic_version

" Sanity checks {{{1
Expand Down
1 change: 0 additions & 1 deletion plugin/syntastic/registry.vim
View file
Expand Up @@ -66,7 +66,6 @@ let s:defaultCheckers = {
\ 'racket': ['racket'],
\ 'rst': ['rst2pseudoxml'],
\ 'ruby': ['mri'],
\ 'rust': ['rustc'],
\ 'sass': ['sass'],
\ 'scala': ['fsc', 'scalac'],
\ 'scss': ['sass', 'scss_lint'],
Expand Down
42 changes: 0 additions & 42 deletions syntax_checkers/rust/rustc.vim
View file

This file was deleted.

6 comments on commit 1383c0f

@lilyball
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrible. Why was it removed? People can customize syntastic to their liking, but having the basic rustc checker with defaults present is far better than not having it at all. Now every single person who wants to get basic Rust syntax checking will have to configure an external checker, instead of the previous situation where only the subset of people unhappy with the defaults were required to change things.

@chris-morgan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kballard: I was actually wondering whether we would be better to maintain it ourselves for the moment, storing it in the Rust repository with our other Vim configuration. I would certainly approve of any PR on mozilla/rust doing this.

@lcd047
Copy link
Collaborator Author

@lcd047 lcd047 commented on 1383c0f Jun 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it removed?

Because keeping it in syntastic had become toxic. The way I see it, my options would have been:

  1. Do nothing and keep arguing about a default, for ever and ever, happily ever after.
  2. Give in and change back the default, then keep flipping it back and forth every time somebody vocal enough asked me to.
  3. Remove the checker that has generated the toxic situation.
  4. Step down from syntastic and go on with my life.

Please note that this had nothing to do with the default itself, the technical merits of one position or the other, or with who was right or wrong (if any, that is). It's just that I'm currently the only active maintainer of syntastic, and I'm doing it purely for fun. Dealing with people that are willing to drag me through a 20 messages' thread for a default, then make a PR after being told they won't get it their way, is not exactly my idea of fun. At the time, removing the checker seemed the least destructive way to sanity. Two days later, stepping down is still on the table, if you guys think it would be the preferred way forward. shrug

I was actually wondering whether we would be better to maintain it ourselves for the moment, storing it in the Rust repository with our other Vim configuration.

It has already been adopted in rust.vim, with, of course, the changed default. :) As it is, it's still missing a reference to the rust filetype in g:syntastic_extra_filetypes, since rust is no longer known to syntastic (see the wiki for details). If you guys come to an agreement that this is a good home for it, I'll add a link to rust.vim from the README.

@chris-morgan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcd047 I entirely understand your position; I’ve been a maintainer on a couple of open source projects myself and have seen such situations. Moving maintenance of it over to the Rust seems to me a reasonable path forwards. As for where it goes, it should have gone into mozilla/rust, the canonical source of Vim config for Rust; I’m not sure why @BurntSushi put it in wting/rust.vim and I’m not sure why @wting accepted it there—until then, wting/rust.vim had been just a straight copy of src/etc/vim from mozilla/rust (working around deficiencies in Git).

I wish you joy with Syntastic; I enjoy using it, and I’d hate to see it become an unhappy burden for you.

@lcd047
Copy link
Collaborator Author

@lcd047 lcd047 commented on 1383c0f Jun 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as I said, just let me know which is the preferred address for it, and I'll add a link.

@BurntSushi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dealing with people that are willing to drag me through a 20 messages' thread for a default, then make a PR after being told they won't get it their way

Almost all of those messages were me trying to explain my problem to you (not about persuading you to change the default) after you declared my solution as wrong. I'm sorry if you thought otherwise. I only asked to change the default back to what it was when you proclaimed that Rust's workflow was too complex for Syntastic, which was because of the default setting.

I've submitted a PR upstream: rust-lang/rust#14924

Please sign in to comment.