Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username to local user deletion confirmation dialog. #2706

Closed
1 task done
jtrosper opened this issue Apr 21, 2022 · 4 comments · Fixed by #2779
Closed
1 task done

Add username to local user deletion confirmation dialog. #2706

jtrosper opened this issue Apr 21, 2022 · 4 comments · Fixed by #2779
Assignees

Comments

@jtrosper
Copy link

Description

The local user deletion confirmation dialog currently prompts: "Are you sure you want to delete this user? All of their request data will be permanently removed." There is currently no information presented to the person initiating the deletion which user for which they've clicked the delete button.

Desired Behavior

Modify the deletion confirmation dialog with language similar to: "Are you sure you want to delete User X?"

Additional Context

No response

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@sct
Copy link
Owner

sct commented Apr 21, 2022

This is a good idea! We can definitely add this.

@sct sct added priority:low good first issue Good for newcomers help wanted Extra attention is needed and removed awaiting-triage labels Apr 21, 2022
@ankarhem
Copy link
Contributor

Could have the user confirm the deletion by typing the username, similar to when deleting a repo

@OwsleyJr OwsleyJr self-assigned this May 13, 2022
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 19, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706

feat: username will show confirming you are deleting the correct one

Adding username implementation that will show the correct user in delete modal and will ask to
confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
The user delete modal will now show the username associated with each user ID and will ask to confirm before deletion.

feat #2706
OwsleyJr added a commit that referenced this issue May 24, 2022
The user delete modal will now show the username associated with each user ID and will ask to confirm before deletion.

feat #2706
@stale
Copy link

stale bot commented Jul 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 13, 2022
@stale stale bot closed this as completed Jul 31, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants