New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decouple Plex as a requirement for setting up/using Overseerr #3015
base: develop
Are you sure you want to change the base?
Conversation
0f30ece
to
a231eba
Compare
This pull request introduces 1 alert when merging a231eba into 30141f7 - view on LGTM.com new alerts:
|
1 flaky tests on run #2043 ↗︎
Details:
cypress/e2e/settings/discover-customization.cy.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
For those who have patiently been waiting for this, it's still in progress! I am trying to sneak in time to get this done this new year's vacation. It's super close, so please wait just a little bit longer! 🙏 |
I'm looking forward for this 🎉 |
Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation! |
We are still working on it! |
Is there a way to help, and most importantly, what is the estimated release date? That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements? If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project. Please let us know the best way to collaborate to get this feature released. |
We don't provide ETAs. We spare whatever free time we have and that's the best I can tell you in terms of delivery time. I am aware of Jellyseerr. That's the beauty of open source. We also now have an internal roadmap with Jellyseerr devs we are referencing to get Jellyfin support back ported to Overseerr once this is merged. I know people are waiting for this. It's close. Just hang on a bit longer. |
dccd0d2
to
8008312
Compare
8008312
to
e9545d4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f*ck you stale bot |
Can't wait for this to be merged. I assume this is purely a structural change to allow for jellyfin/emby but doesn't directly add them? |
Has there been any movement here? I have still have #3105 open which was tacitly waiting on this work to shake out, but it's not clear to me if this work has stalled entirely or what. |
This comment was marked as resolved.
This comment was marked as resolved.
yikes. Unstale please |
I suggest adding the never-stale label to avoid our friendly stale-bot freaking folks out as core careful decoupling like this takes a lotta time and effort to get right. |
This is the first of a few commits to fully decouple Plex from Oversneedrr. It's based on the pull request from the upstream repo: sct#3015 There is some real concerns I have which I have marked with FIXME's, some stuff seems to be hacky to my non-TypeScript adjusted eyes, and I don't think it's a full decoupling. I will probably have to add some tweaks. This doesn't include the frontend bits.
Is this still being worked on? |
Considering the dev teams reluctance to provide ETAs and refusal of further assistance in this thread I'm guessing no. It doesn't seem that any of them use Jellyfin so it seems we should be content with Jellyseer for the forseable future or just move to Ombi. 🤷♂️ |
Description
This is the first step to opening up Overseerr to allow other media server integrations. Previously, Overseerr required signing in with a Plex account to get it configured. You can now create a local account instead of using Plex. If a local account is used, you will need to connect your Plex account still to use the Plex Media Server features.
Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract