Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple Plex as a requirement for setting up/using Overseerr #3015

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

sct
Copy link
Owner

@sct sct commented Sep 12, 2022

Description

This is the first step to opening up Overseerr to allow other media server integrations. Previously, Overseerr required signing in with a Plex account to get it configured. You can now create a local account instead of using Plex. If a local account is used, you will need to connect your Plex account still to use the Plex Media Server features.

Screenshot (if UI-related)

image
image

To-Dos

  • Decouple plex from the setup process
  • Remove UserType from users (opens possibility for multiple user types per user)
  • Add option to link/unlink Plex account from user settings (instead of only while logging in)
  • Allow changing emails
  • Disable Plex login when owner account does not have plex configured
  • Do not allow new plex connections to accounts if owner account unlinks plex
  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

This was referenced Sep 12, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 12, 2022

This pull request introduces 1 alert when merging a231eba into 30141f7 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@cypress
Copy link

cypress bot commented Sep 12, 2022

1 flaky tests on run #2043 ↗︎

0 28 0 0 Flakiness 1

Details:

feat: decouple Plex as a requirement for setting up/using Overseerr
Project: overseerr Commit: abcf78f966
Status: Passed Duration: 05:02 💡
Started: Aug 6, 2023 7:43 AM Ended: Aug 6, 2023 7:48 AM
Flakiness  cypress/e2e/settings/discover-customization.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Discover Customization > can create a new discover option and remove it Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stale
Copy link

stale bot commented Nov 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2022
@stale stale bot closed this Nov 22, 2022
@sct sct reopened this Nov 24, 2022
@stale stale bot removed the stale label Nov 24, 2022
@sct
Copy link
Owner Author

sct commented Dec 29, 2022

For those who have patiently been waiting for this, it's still in progress! I am trying to sneak in time to get this done this new year's vacation. It's super close, so please wait just a little bit longer! 🙏

@DimitriDR
Copy link
Contributor

I'm looking forward for this 🎉

@sypion
Copy link

sypion commented Feb 4, 2023

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

@sct
Copy link
Owner Author

sct commented Feb 4, 2023

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

We are still working on it!

@brettp
Copy link

brettp commented Feb 4, 2023

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

@sct
Copy link
Owner Author

sct commented Feb 4, 2023

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

We don't provide ETAs. We spare whatever free time we have and that's the best I can tell you in terms of delivery time.

I am aware of Jellyseerr. That's the beauty of open source. We also now have an internal roadmap with Jellyseerr devs we are referencing to get Jellyfin support back ported to Overseerr once this is merged.

I know people are waiting for this. It's close. Just hang on a bit longer.

@stale

This comment was marked as resolved.

@stale stale bot added the stale label May 1, 2023
@aleksasiriski
Copy link

f*ck you stale bot

@CEbbinghaus
Copy link

Can't wait for this to be merged. I assume this is purely a structural change to allow for jellyfin/emby but doesn't directly add them?

@tobz
Copy link

tobz commented Jun 23, 2023

Has there been any movement here?

I have still have #3105 open which was tacitly waiting on this work to shake out, but it's not clear to me if this work has stalled entirely or what.

@stale

This comment was marked as resolved.

@stale stale bot added the stale label Oct 15, 2023
@CEbbinghaus
Copy link

yikes. Unstale please

@stale stale bot removed the stale label Oct 15, 2023
@mattkatz
Copy link

I suggest adding the never-stale label to avoid our friendly stale-bot freaking folks out as core careful decoupling like this takes a lotta time and effort to get right.

samicrusader added a commit to Fat-Cats-LLC/overseerr that referenced this pull request Dec 25, 2023
This is the first of a few commits to fully decouple Plex from Oversneedrr. It's based on the pull request from the upstream repo: sct#3015

There is some real concerns I have which I have marked with FIXME's, some stuff seems to be hacky to my non-TypeScript adjusted eyes, and I don't think it's a full decoupling. I will probably have to add some tweaks.

This doesn't include the frontend bits.
@Emalton
Copy link

Emalton commented Apr 7, 2024

Is this still being worked on?

@gunanr
Copy link

gunanr commented Apr 12, 2024

Is this still being worked on?

Considering the dev teams reluctance to provide ETAs and refusal of further assistance in this thread I'm guessing no. It doesn't seem that any of them use Jellyfin so it seems we should be content with Jellyseer for the forseable future or just move to Ombi. 🤷‍♂️

@tenfourty tenfourty mentioned this pull request Apr 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet