fix(scully-plugin-puppeteer): rename onRenderReady event to prevent…

… zone.js patching (#1597)
scullyio · Jul 15, 2022 · e2fb21f · e2fb21f
1 parent e794aae
commit e2fb21f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libs/plugins/scully-plugin-playwright/src/lib/plugins-scully-plugin-playwright.ts b/libs/plugins/scully-plugin-playwright/src/lib/plugins-scully-plugin-playwright.ts
@@ -51,7 +51,7 @@ export const playwrightRenderer = async (route: HandledRoute): Promise<string> =
     }
 
     /** this will be called from the browser, but runs in node */
-    await page.exposeFunction('onRenderReady', () => {
+    await page.exposeFunction('pageRenderReady', () => {
       resolve();
     });
 
@@ -79,7 +79,7 @@ export const playwrightRenderer = async (route: HandledRoute): Promise<string> =
       /** set "running" mode */
       window['ScullyIO'] = 'running';
       window.addEventListener('AngularReady', () => {
-        window['onRenderReady']();
+        window['pageRenderReady']();
       });
     });
 

diff --git a/libs/plugins/scully-plugin-puppeteer/src/lib/plugins-scully-plugin-puppeteer.ts b/libs/plugins/scully-plugin-puppeteer/src/lib/plugins-scully-plugin-puppeteer.ts
@@ -96,7 +96,7 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
     }
 
     /** this will be called from the browser, but runs in node */
-    await page.exposeFunction('onRenderReady', () => {
+    await page.exposeFunction('pageRenderReady', () => {
       resolve();
     });
 
@@ -125,7 +125,7 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
       /** set "running" mode */
       window['ScullyIO'] = 'running';
       window.addEventListener('AngularReady', () => {
-        window['onRenderReady']();
+        window['pageRenderReady']();
       });
     });