fix(scully-plugin-puppeteer): rename onRenderReady event to prevent zone.js patching
#1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zone.js patching
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Since version 0.11.5 Zone.Js patches all window properties started from
onprefix. Puppeteer plugin usesonRenderReadyevent to notify puppetteer. So Zone patching makes impossible for puppeteer to receive such event, which causing to always wait for default 25sec timeout on Scully build for Angular projects.Issue Number: N/A
What is the new behavior?
Puppeteer doesn't always wait for timeout and processes correctly.
Does this PR introduce a breaking change?
Other information
One can suppress Zone patching of the
onRenderReadyevent in the projects manually, but it would be great to have solution working out-of-the-box. And the simplest way to fix it is to rename the event. So this PR does it.