fix(scully): kill background server on exit #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will forcefully kill the background server when scully is done processing ISSUES CLOSED: #1513
gn-sky
approved these changes
Feb 1, 2022
SanderElias
added a commit
that referenced
this pull request
Feb 10, 2022
* feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see #1529 (#1533) * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see #1529 ISSUES CLOSED: #1529 * fix(monorepo): add workaround for [#22606](angular/angular-cli#22606) * test(ng-lib): add test to check if tss works with route-resolvers * fix(scully): kill background server on exit (#1535) * chore(monorepo): upgrade to latest angular, NX, and formatting stds * refactor(actions): switch to max 8 parrallel on nx build
10 tasks
Jefiozie
added a commit
that referenced
this pull request
Mar 9, 2022
* feat(platform-server): limit to version 12, as version 13 needs ESM (#1522) * chore: bump version and tag it to 2.1.7 * Bump marked to resolve security advisory (#1526) * fix(scully): upgrade marked version * fix(scully): upgrade @types/marked * chore: bump version and tag it to 2.1.8 * ci: add codeql scanning to the workflow (#1528) * chore: bump version and tag it to 2.1.9 * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see #1529 (#1533) * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see #1529 ISSUES CLOSED: #1529 * fix(monorepo): add workaround for [#22606](angular/angular-cli#22606) ISSUES CLOSED: #1529 * test(ng-lib): add test to check if tss works with route-resolvers ISSUES CLOSED: #1529 * chore: bump version and tag it to 2.1.10 * fix(scully): kill background server on exit (#1535) This will forcefully kill the background server when scully is done processing ISSUES CLOSED: #1513 * chore: bump version and tag it to 2.1.11 * chore(deps): bump nanoid from 3.1.30 to 3.2.0 (#1534) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.12 * chore(deps): bump follow-redirects from 1.14.6 to 1.14.8 (#1540) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.6 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.6...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.13 * fix(ng-lib): don't error when routing from non-Scully page to Scully-genreated page (#1541) * chore: bump version and tag it to 2.1.14 * chore(deps): bump url-parse from 1.5.4 to 1.5.7 (#1542) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.4...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.15 * Added spanish translations responding to issue #1321 (#1445) * Added spanish translations responding to issue #1321 * Update docs/learn/create-a-plugin/create-a-plugin_es.md Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Sander Elias <SanderElias@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> * chore: bump version and tag it to 2.1.16 * chore(monorepo): merge in main * chore(deps): bump prismjs from 1.25.0 to 1.27.0 (#1548) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.25.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.17 * fix(schematics): Get schematic tests running and passing plus add logic for gitignore (#1547) entries * chore: bump version and tag it to 2.1.18 * chore(monorepo): update depedencies (PPT & PW) to try fixing some scuritty warings (#1551) * chore: bump version and tag it to 2.1.19 * fix(scully): update selfsigned to fix security issue when using SSL selfsigned certifiates (#1552) * chore: bump version and tag it to 2.1.20 * fix(schematics): make sure the schematics install the latest version off our playwright plugin, instead of 0.0.2 (#1554) * chore: bump version and tag it to 2.1.21 * refactor(Actions): we don't need to build after the build-artifacts, because its already there (#1555) * chore: bump version and tag it to 2.1.22 * test: updated configuration to run tests for schematics and sps, univ… (#1482) * chore: bump version and tag it to 2.1.23 * chore(monorepo): updating deps * chore(monorepo): upgrade to latest nx * chore(monorepo): bump version * fix(actions): fix on node version 16.13.2 untill next node versions are released * fix(scully): update deps for ESM use * fix(scully-plugin-puppeteer): correct depedency import, move from peerdeps to deps (it was in scully Co-authored-by: Scully-Bot <Scully-Bot@users.noreply.github.com> Co-authored-by: Zsofia Florek <58311322+zsofiaflorek@users.noreply.github.com> Co-authored-by: Jeffrey Bosch <Jefiozie@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: manueldose <71591743+manueldose@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Mike Brocchi <mbrocchi@gmail.com>
fredericbirke
pushed a commit
to fredericbirke/scully_f
that referenced
this pull request
Feb 18, 2023
* feat(platform-server): limit to version 12, as version 13 needs ESM (scullyio#1522) * chore: bump version and tag it to 2.1.7 * Bump marked to resolve security advisory (scullyio#1526) * fix(scully): upgrade marked version * fix(scully): upgrade @types/marked * chore: bump version and tag it to 2.1.8 * ci: add codeql scanning to the workflow (scullyio#1528) * chore: bump version and tag it to 2.1.9 * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 (scullyio#1533) * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 ISSUES CLOSED: scullyio#1529 * fix(monorepo): add workaround for [#22606](angular/angular-cli#22606) ISSUES CLOSED: scullyio#1529 * test(ng-lib): add test to check if tss works with route-resolvers ISSUES CLOSED: scullyio#1529 * chore: bump version and tag it to 2.1.10 * fix(scully): kill background server on exit (scullyio#1535) This will forcefully kill the background server when scully is done processing ISSUES CLOSED: scullyio#1513 * chore: bump version and tag it to 2.1.11 * chore(deps): bump nanoid from 3.1.30 to 3.2.0 (scullyio#1534) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.12 * chore(deps): bump follow-redirects from 1.14.6 to 1.14.8 (scullyio#1540) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.6 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.6...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.13 * fix(ng-lib): don't error when routing from non-Scully page to Scully-genreated page (scullyio#1541) * chore: bump version and tag it to 2.1.14 * chore(deps): bump url-parse from 1.5.4 to 1.5.7 (scullyio#1542) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.4...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.15 * Added spanish translations responding to issue scullyio#1321 (scullyio#1445) * Added spanish translations responding to issue scullyio#1321 * Update docs/learn/create-a-plugin/create-a-plugin_es.md Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Sander Elias <SanderElias@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> * chore: bump version and tag it to 2.1.16 * chore(monorepo): merge in main * chore(deps): bump prismjs from 1.25.0 to 1.27.0 (scullyio#1548) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.25.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.17 * fix(schematics): Get schematic tests running and passing plus add logic for gitignore (scullyio#1547) entries * chore: bump version and tag it to 2.1.18 * chore(monorepo): update depedencies (PPT & PW) to try fixing some scuritty warings (scullyio#1551) * chore: bump version and tag it to 2.1.19 * fix(scully): update selfsigned to fix security issue when using SSL selfsigned certifiates (scullyio#1552) * chore: bump version and tag it to 2.1.20 * fix(schematics): make sure the schematics install the latest version off our playwright plugin, instead of 0.0.2 (scullyio#1554) * chore: bump version and tag it to 2.1.21 * refactor(Actions): we don't need to build after the build-artifacts, because its already there (scullyio#1555) * chore: bump version and tag it to 2.1.22 * test: updated configuration to run tests for schematics and sps, univ… (scullyio#1482) * chore: bump version and tag it to 2.1.23 * chore(monorepo): updating deps * chore(monorepo): upgrade to latest nx * chore(monorepo): bump version * fix(actions): fix on node version 16.13.2 untill next node versions are released * fix(scully): update deps for ESM use * fix(scully-plugin-puppeteer): correct depedency import, move from peerdeps to deps (it was in scully Co-authored-by: Scully-Bot <Scully-Bot@users.noreply.github.com> Co-authored-by: Zsofia Florek <58311322+zsofiaflorek@users.noreply.github.com> Co-authored-by: Jeffrey Bosch <Jefiozie@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: manueldose <71591743+manueldose@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Mike Brocchi <mbrocchi@gmail.com>
fredericbirke
pushed a commit
to fredericbirke/scully_f
that referenced
this pull request
Feb 18, 2023
* feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 (scullyio#1533) * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 ISSUES CLOSED: scullyio#1529 * fix(monorepo): add workaround for [#22606](angular/angular-cli#22606) * test(ng-lib): add test to check if tss works with route-resolvers * fix(scully): kill background server on exit (scullyio#1535) * chore(monorepo): upgrade to latest angular, NX, and formatting stds * refactor(actions): switch to max 8 parrallel on nx build
fredericbirke
pushed a commit
to fredericbirke/scully_f
that referenced
this pull request
Feb 19, 2023
* feat(platform-server): limit to version 12, as version 13 needs ESM (scullyio#1522) * chore: bump version and tag it to 2.1.7 * Bump marked to resolve security advisory (scullyio#1526) * fix(scully): upgrade marked version * fix(scully): upgrade @types/marked * chore: bump version and tag it to 2.1.8 * ci: add codeql scanning to the workflow (scullyio#1528) * chore: bump version and tag it to 2.1.9 * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 (scullyio#1533) * feat(ng-lib): use GuardsCheckEnd instead of Navigationend. see scullyio#1529 ISSUES CLOSED: scullyio#1529 * fix(monorepo): add workaround for [#22606](angular/angular-cli#22606) ISSUES CLOSED: scullyio#1529 * test(ng-lib): add test to check if tss works with route-resolvers ISSUES CLOSED: scullyio#1529 * chore: bump version and tag it to 2.1.10 * fix(scully): kill background server on exit (scullyio#1535) This will forcefully kill the background server when scully is done processing ISSUES CLOSED: scullyio#1513 * chore: bump version and tag it to 2.1.11 * chore(deps): bump nanoid from 3.1.30 to 3.2.0 (scullyio#1534) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.12 * chore(deps): bump follow-redirects from 1.14.6 to 1.14.8 (scullyio#1540) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.6 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.6...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.13 * fix(ng-lib): don't error when routing from non-Scully page to Scully-genreated page (scullyio#1541) * chore: bump version and tag it to 2.1.14 * chore(deps): bump url-parse from 1.5.4 to 1.5.7 (scullyio#1542) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.4...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.15 * Added spanish translations responding to issue scullyio#1321 (scullyio#1445) * Added spanish translations responding to issue scullyio#1321 * Update docs/learn/create-a-plugin/create-a-plugin_es.md Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Sander Elias <SanderElias@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> * chore: bump version and tag it to 2.1.16 * chore(monorepo): merge in main * chore(deps): bump prismjs from 1.25.0 to 1.27.0 (scullyio#1548) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.25.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump version and tag it to 2.1.17 * fix(schematics): Get schematic tests running and passing plus add logic for gitignore (scullyio#1547) entries * chore: bump version and tag it to 2.1.18 * chore(monorepo): update depedencies (PPT & PW) to try fixing some scuritty warings (scullyio#1551) * chore: bump version and tag it to 2.1.19 * fix(scully): update selfsigned to fix security issue when using SSL selfsigned certifiates (scullyio#1552) * chore: bump version and tag it to 2.1.20 * fix(schematics): make sure the schematics install the latest version off our playwright plugin, instead of 0.0.2 (scullyio#1554) * chore: bump version and tag it to 2.1.21 * refactor(Actions): we don't need to build after the build-artifacts, because its already there (scullyio#1555) * chore: bump version and tag it to 2.1.22 * test: updated configuration to run tests for schematics and sps, univ… (scullyio#1482) * chore: bump version and tag it to 2.1.23 * chore(monorepo): updating deps * chore(monorepo): upgrade to latest nx * chore(monorepo): bump version * fix(actions): fix on node version 16.13.2 untill next node versions are released * fix(scully): update deps for ESM use * fix(scully-plugin-puppeteer): correct depedency import, move from peerdeps to deps (it was in scully Co-authored-by: Scully-Bot <Scully-Bot@users.noreply.github.com> Co-authored-by: Zsofia Florek <58311322+zsofiaflorek@users.noreply.github.com> Co-authored-by: Jeffrey Bosch <Jefiozie@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: manueldose <71591743+manueldose@users.noreply.github.com> Co-authored-by: Andrés Villanueva <andresvillanuevab@gmail.com> Co-authored-by: Mike Brocchi <mbrocchi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will forcefully kill the background server when scully is done processing
ISSUES CLOSED: #1513
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information