Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis support for OS X tests and PHP 7.3 #399

Merged
merged 6 commits into from Dec 9, 2018

Conversation

beryllium
Copy link
Member

@beryllium beryllium commented Nov 21, 2018

Travis now has experimental support for testing under OS X (and Windows, but that doesn't seem to play nicely with PHP yet). Maybe it will help Sculpin to try and test under these common user envs.

Technically their Windows support doesn't include PHP, and their OS X support may not support it either. Let's find out. (Update: discovered that yes, OS X can be done, but Windows is still difficult.)

@beryllium
Copy link
Member Author

Well, I was able to get OS X to work, but Windows will be a tough nut to crack. Looks like this guide from jeff geerling might help for manual testing, but could be difficult to follow programmatically inside Travis:

https://www.jeffgeerling.com/blog/2018/installing-php-7-and-composer-on-windows-10

@lex111
Copy link
Contributor

lex111 commented Dec 8, 2018

Apparently, now we can not integrate Windows:

The language 'ruby' is currently unsupported on the Windows Build Environment.

By the way, can migrate to PHP 7.3?

@beryllium
Copy link
Member Author

I don't think we should move the composer.json requirements to 7.3 for this version, since 7.2 is still the default in some widely-available systems. I've added 7.3 support to travis, though, which should help ensure some stability there.

Even though this PR is about Windows, I had significant difficulty getting it to build under Travis. I was able to test it out locally using a Windows VM and everything seemed to work.

@WyriHaximus
Copy link
Member

@beryllium have you consired AppVeyor for Windows?

WyriHaximus added a commit to WyriHaximus/php-file-descriptors that referenced this pull request Dec 8, 2018
packages:
- php
- composer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simplefies my own set up so much, thank you 👍 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lex111
Copy link
Contributor

lex111 commented Dec 9, 2018

You can also consider using GitLab CI...

@beryllium beryllium changed the title Add travis support for Windows and OS X tests Add travis support for OS X tests and PHP 7.3 Dec 9, 2018
@beryllium beryllium merged commit 96ddb6d into sculpin:master Dec 9, 2018
@beryllium beryllium deleted the windows-travis branch December 9, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants