Weird behaviour on toJSON method

[danielbdias]

When you fill a child element with an invalid value toJSON method acts in a weird way. The parent toJSON returns the old child element and the toJSON of the child element returns the child element in the invalid state.

For example, given the schema:

class MyEntity extends Speck {
  static SCHEMA = {
    field: PropTypes.string,
    anotherField: PropTypes.string
  }
}

class FatherEntity extends Speck {
  static SCHEMA = {
    child: PropTypes.instanceOf(MyEntity)
  }
}

And the variables setup:

const a = new FatherEntity({ child: { field: 'value' } })
a.child = { field: 'invalid entity', anotherField: 'yet a invalid entity' }

The toJSON method have this behaviour:

//prints { child: { field: 'value' } }
console.log(a.toJSON()) 
//prints { field: 'invalid entity', anotherField: 'yet a invalid entity' }
console.log(a.child.toJSON()) 

[guisouza]

try with :

class FatherEntity extends Speck {
  static SCHEMA = {
    child: {
      validator: PropTypes.instanceOf(MyEntity),
      type: MyEntity
    }
  }
}

[guisouza]

@danielbdias should we close this issue ?

[danielbdias]

Please, @guisouza not yet, can you wait two more days? I will do one more test to simulate this error (and another to use your solution).
Thanks !

[guisouza]

No problem, take your time ..

[danielbdias]

I can't simulate this error anymore. For now I think that is better to close this issue.