Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for hdf5plugin compression usage when writing to h5ad #857

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

nigeil
Copy link
Contributor

@nigeil nigeil commented Nov 23, 2022

Following up on the discussion around #828, the changes in this new PR add documentation related to hdf5plugin library usage for anndata.write_h5ad. Users are pointed to the relevant documentation from that project, usage examples are provided, and caveats related to reading hdf5plugin-compressed datasets are noted!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #857 (eec419a) into master (385bb5a) will not change coverage.
The diff coverage is n/a.

❗ Current head eec419a differs from pull request most recent head ea61ff6. Consider uploading reports for the commit ea61ff6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          32       32           
  Lines        4365     4365           
=======================================
  Hits         3649     3649           
  Misses        716      716           
Impacted Files Coverage Δ
anndata/_core/anndata.py 82.81% <ø> (ø)

Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add a release note to 0.9 under doc changes?

@ivirshup ivirshup added the docs label Dec 1, 2022
@ivirshup ivirshup added this to the 0.9 milestone Dec 1, 2022
@ivirshup ivirshup enabled auto-merge (squash) December 2, 2022 17:07
@ivirshup
Copy link
Member

ivirshup commented Dec 2, 2022

Actually, I want to do some fiddling with the docs that would make conflicts, so I've gone ahead and added a release note. Let me know if you'd want me to rephrase

Thanks for the PR!

@ivirshup ivirshup merged commit 3b45954 into scverse:master Dec 2, 2022
@nigeil
Copy link
Contributor Author

nigeil commented Dec 2, 2022

No problem, thanks for maintaining this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants