Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin older node version for prettier pre-commit hook #144

Merged
merged 10 commits into from
Jan 31, 2023
Merged

Pin older node version for prettier pre-commit hook #144

merged 10 commits into from
Jan 31, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Jan 17, 2023

Fix #143

@github-actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#36

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@grst grst requested a review from giovp January 17, 2023 10:03
Zethson
Zethson reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure whether I want the version pinned in the template. Maybe something that should rather be in the docs?
How many people are affected by this? I saw the issue...

@grst
Copy link
Collaborator Author

grst commented Jan 17, 2023

It affects everyone on Ubuntu 18.04, which I'm afraid is still rather common.

@Zethson
Copy link
Member

Zethson commented Jan 17, 2023

Sadly you are correct.
The support for 18.x ends in April 2023 but is only EOL in 2028.

DW, I won't block this PR, but these kinds of fixes that at one point might get forgotten annoy me :) Thank you for looking into it!

@grst
Copy link
Collaborator Author

grst commented Jan 17, 2023

18.10 should work though.

Not sure about other OS. The linked jupyterhub issue also mentions amazon linux.
Maybe let's just float this around for a while and see if more people complain.

@grst grst mentioned this pull request Jan 18, 2023
Closed
@grst grst mentioned this pull request Jan 30, 2023
Closed
@moinfar moinfar mentioned this pull request Jan 30, 2023
Merged
3 tasks
@grst grst requested a review from Zethson January 30, 2023 13:17
@grst grst mentioned this pull request Jan 30, 2023
Closed
Zethson
Zethson approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@Zethson Zethson merged commit 7b86b35 into main Jan 31, 2023
@Zethson Zethson deleted the grst-patch-1 branch January 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

@giovp giovp Awaiting requested review from giovp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pre-commit/repoxoi92sgz/node_env-default/bin/node: libc.so.6: version `GLIBC_2.28' not found
2 participants
@grst @Zethson