Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib lower bound causes issues in google colab #2413

Closed
adamgayoso opened this issue Feb 14, 2023 · 2 comments
Closed

Matplotlib lower bound causes issues in google colab #2413

adamgayoso opened this issue Feb 14, 2023 · 2 comments

Comments

@adamgayoso
Copy link
Member

"matplotlib>=3.4",

Colab has 3.2.2 installed and installing scanpy requires restarting the runtime. I also can't find a great reason why 3.4 was chosen

#2212

based on this 3.2.2 should be fine?

@flying-sheep
Copy link
Member

flying-sheep commented Nov 8, 2023

#2733 bumps the minimum version up to 3.6 and adds two good reasons why that exact minimum version requirement is chosen:

  1. matplotlib’s maintenance schedule drops support for 3.5 in a little bit
  2. we use a feature from 3.5

If some piece of infrastructure doesn’t allow bumping versions of client libraries, that piece of infrastructure needs improvement. Jupyter allows distinct environments for kernels and the server for a reason. So while colab should be able to pin and use whatever they need on the server, there’s zero reason why colab should dictate any version of anything other than ipykernel for the user environment.

@flying-sheep flying-sheep closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
@ivirshup
Copy link
Member

ivirshup commented Nov 8, 2023

Default matplotlib in colab seems to be 3.7 now also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants