Require matplotlib 3.6+ for colormaps #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2733 +/- ##
=======================================
Coverage 72.92% 72.92%
=======================================
Files 111 111
Lines 12134 12134
=======================================
Hits 8849 8849
Misses 3285 3285 |
|
See also: conda-forge/scanpy-feedstock#12 [edited to fixed change] |
|
@ivirshup I assume you caught that in your minimal-dependencies branch already? Maybe it’s a good time to push it! |
`matplotlib.colormaps` was introduced in v3.5.0, but scanpy currently specifies only v3.4+, and uses other features introduced in 3.6. Bump it and everything should be fine.
thetorpedodog
force-pushed
the
matplotlib-colormaps
branch
from
6a71a5a
to
e8fcb34
Compare
flying-sheep
changed the title
|
Do you want to add a release note entry? |
Added. I believe I got the format right. |
|
@flying-sheep @thetorpedodog be aware of #2413 |
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Nov 8, 2023
flying-sheep
pushed a commit
that referenced
this pull request
Nov 8, 2023
…aps) (#2738) Co-authored-by: paul fisher <paul@pfish.zone>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matplotlib.colormapswas introduced in v3.5.0, but scanpy currently specifies only v3.4+. Bump it and everything should be fine.(this is just my own evaluation of triviality; if you want a release notes entry I am happy to add one)