groupby is converted to a list before adding as dendrogram key
#1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokceneraslan
requested changes
Oct 24, 2020
|
Thanks, looks good. |
ivirshup
removed
the
Maint – Backport needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you specify
groupbytosc.tl.dendrogram, but notdendrogram_key, storage (and subsequent retrieval) fromadata.unsis messed up becausegroupbyis converted fromstr-->listduring computation.To give a more concrete example, if my
groupbyvariable was "cell_subtype", I would expect it to be stored inadata.unsas "dendrogram_cell_subtype". However, because of the list conversion it's stored as "dendrogram_['cell_subtype']" (shown below)This PR attempts to address that. I'm not sure if this is the way you want to go about fixing it, but it's one option.
Thanks for the great package!