Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupby is converted to a list before adding as dendrogram key #1465

Merged
merged 7 commits into from
Oct 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion scanpy/plotting/_anndata.py
Original file line number Diff line number Diff line change
Expand Up @@ -2112,7 +2112,10 @@ def _get_dendrogram_key(adata, dendrogram_key, groupby):
# the `dendrogram_key` can be a bool an NoneType or the name of the
# dendrogram key. By default the name of the dendrogram key is 'dendrogram'
if not isinstance(dendrogram_key, str):
dendrogram_key = f'dendrogram_{groupby}'
if isinstance(groupby, str):
dendrogram_key = f'dendrogram_{groupby}'
elif isinstance(groupby, list):
dendrogram_key = f'dendrogram_{"_".join(groupby)}'

if dendrogram_key not in adata.uns:
from ..tools._dendrogram import dendrogram
Expand Down
25 changes: 25 additions & 0 deletions scanpy/tests/test_dendrogram_key_added.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import scanpy as sc
import numpy as np
import pytest

n_neighbors = 5
key = 'test'


@pytest.fixture
def adata():
return sc.AnnData(sc.datasets.pbmc68k_reduced())


@pytest.mark.parametrize('groupby', ['bulk_labels', ['bulk_labels', 'phase']])
@pytest.mark.parametrize('key_added', [None, "custom_key"])
def test_dendrogram_key_added(adata, groupby, key_added):
sc.tl.dendrogram(adata, groupby=groupby, key_added=key_added, use_rep="X_pca")
if isinstance(groupby, list):
dendrogram_key = f'dendrogram_{"_".join(groupby)}'
else:
dendrogram_key = f'dendrogram_{groupby}'

if key_added is None:
key_added = dendrogram_key
assert key_added in adata.uns
2 changes: 1 addition & 1 deletion scanpy/tools/_dendrogram.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def dendrogram(

if inplace:
if key_added is None:
key_added = f'dendrogram_{groupby}'
key_added = f'dendrogram_{"_".join(groupby)}'
logg.info(f'Storing dendrogram info using `.uns[{key_added!r}]`')
adata.uns[key_added] = dat
else:
Expand Down