Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit layer argument in _highly_variable_genes_single_batch when using sc.pp.highly_variable_genes #2183

Closed
wants to merge 1 commit into from

Conversation

Ngort
Copy link

@Ngort Ngort commented Mar 18, 2022

Quite a simple addition meant to fix a bug when one works with specific layers.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #2183 (1cba9ed) into master (805bd63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2183   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          92       92           
  Lines       11283    11283           
=======================================
  Hits         8054     8054           
  Misses       3229     3229           
Impacted Files Coverage Δ
scanpy/preprocessing/_highly_variable_genes.py 94.24% <ø> (ø)

@Zethson
Copy link
Member

Zethson commented Mar 21, 2022

Could you please run black?

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted scanpy/preprocessing/_highly_variable_genes.py

All done! ✨ 🍰 ✨
1 file reformatted, 152 files left unchanged.

@ivirshup
Copy link
Member

That definitely looks wrong on our end....

Can you add a test for this?

@Zethson
Copy link
Member

Zethson commented Feb 15, 2023

@Ngort we'd be happy to get this PR in if you address the comments above.

@DriesSchaumont
Copy link
Contributor

@Ngort we'd be happy to get this PR in if you address the comments above.

@Zethson I think this was fixed in #2302

@Zethson
Copy link
Member

Zethson commented Feb 11, 2024

@DriesSchaumont Thanks!

@Zethson Zethson closed this Feb 11, 2024
@flying-sheep
Copy link
Member

We should make sure to get fixes like this in by fixing style issues with PRs ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants