Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to igraph name #2566

Merged
merged 3 commits into from Jul 21, 2023
Merged

Switch to igraph name #2566

merged 3 commits into from Jul 21, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jul 21, 2023 •
edited

Fixes #2562, fixes #2341

All versions of the old package that used to be published under that name are yanked, so no need to specify a minimum version

@flying-sheep flying-sheep marked this pull request as ready for review July 21, 2023 10:01
@flying-sheep flying-sheep added this to the 1.9.3 milestone Jul 21, 2023
@flying-sheep flying-sheep enabled auto-merge (squash) July 21, 2023 10:04
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited

Codecov Report

Merging #2566 (485dfda) into master (0594b7f) will not change coverage.
The diff coverage is n/a.

❗ Current head 485dfda differs from pull request most recent head f4ab24c. Consider uploading reports for the commit f4ab24c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2566   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files         104      104           
  Lines       11688    11688           
=======================================
  Hits         8430     8430           
  Misses       3258     3258
Impacted Files Coverage Δ
scanpy/logging.py 95.04% <ø> (ø)
scanpy/testing/_pytest/marks.py 84.61% <ø> (ø)

@flying-sheep flying-sheep mentioned this pull request Jul 21, 2023
Closed
3 tasks
Zethson
Zethson approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@flying-sheep flying-sheep merged commit 05068c3 into master Jul 21, 2023
9 checks passed
@flying-sheep flying-sheep deleted the fix-igraph-dep branch July 21, 2023 10:53
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 21, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Jul 21, 2023
@flying-sheep @meeseeksmachine
Backport PR scverse#2566: Switch to igraph name
6419aee
@flying-sheep flying-sheep modified the milestones: 1.9.3, 1.9.4 Jul 21, 2023
flying-sheep added a commit that referenced this pull request Jul 21, 2023
@meeseeksmachine @flying-sheep
Backport PR #2566 on branch 1.9.x (Switch to igraph name) (#2568)
059d00e 
Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

@ivirshup ivirshup Awaiting requested review from ivirshup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.4
2 participants
@flying-sheep @Zethson