Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hatch and Python 3.9 minimum #2695

Merged
merged 6 commits into from Oct 24, 2023
Merged

Switch to hatch and Python 3.9 minimum #2695

merged 6 commits into from Oct 24, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 17, 2023

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2695 (1275fd8) into master (373c585) will decrease coverage by 0.03%.
The diff coverage is 82.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
- Coverage   72.01%   71.99%   -0.03%     
==========================================
  Files         108      107       -1     
  Lines       11934    11914      -20     
==========================================
- Hits         8594     8577      -17     
+ Misses       3340     3337       -3     
Files Coverage Δ
scanpy/neighbors/__init__.py 79.72% <100.00%> (+0.16%) ⬆️
scanpy/__init__.py 81.48% <81.48%> (-18.52%) ⬇️

@flying-sheep flying-sheep added this to the 1.10.0 milestone Oct 23, 2023
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I got triggered with the replacement of a relative file link to LICENSE and a hard coded license :) But I don't expect this to (ever) change.

@flying-sheep
Copy link
Member Author

flying-sheep commented Oct 24, 2023

replacement of a relative file link to LICENSE and a hard coded license

Ah, but that’s not what that is. It’s a switch to PEP 639, which says:

If the license-files key is not present and not explicitly marked as dynamic, tools MUST assume a default value of the following:

license-files.globs = ["LICEN[CS]E*", "COPYING*", "NOTICE*", "AUTHORS*"]

So nothing is lost, the file still gets included.

@flying-sheep flying-sheep merged commit eb87345 into master Oct 24, 2023
11 checks passed
@flying-sheep flying-sheep deleted the python-min-3.9 branch October 24, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants