Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCR dist #11

Closed
1 of 3 tasks
grst opened this issue Apr 9, 2020 · 10 comments
Closed
1 of 3 tasks

TCR dist #11

grst opened this issue Apr 9, 2020 · 10 comments
Assignees

Comments

@grst
Copy link
Collaborator

grst commented Apr 9, 2020

In GitLab by @grst on Jan 24, 2020, 13:50

Getting the alignments was quite straightforward, thanks to parasail.
We said that we focus on CDR3, at least initially.

@szabogtamas, some points to discuss

  • Distance between which chains? primary alpha/beta only?
  • What if a cell does not have either alpha or beta?
  • Right now, I use blosum62 to compute the alignment score. I think in the original publication they cap the max score per amino acid to 4. Does that make sense?

Edit:
Prototype works. ToDo for now.

  • Add clonotype overlap as a distance metric (simple 0-1)
  • keyword argument to choose to compute on primary_only or all chains
  • consider TRA and TRB separately.
@grst grst self-assigned this Apr 9, 2020
@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Jan 24, 2020, 20:23

I think we could leave the decision up to the user. One option would be to ignore secondary chains. The other option would be to have four distances between each pair of cells:

  • TRA1/TRB1
  • TRA2/TRB1
  • TRA1/TRB2
  • TRA2/TRB2
    Then we could take the minimum of that four as the distance metric (or even the maximum makes sense in some cases).
    Just like for sequence logos, I would go with an 'XXXXXXXXXXXXXX' seqeunce. This works well with the current implementation already, making the similarity score as low as possible.

The last point I don't really get. They must have a rationale behind capping the score but for me it would be more logical to use alignment scores as they are... I will try to look into the paper again.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Jan 30, 2020, 11:03

changed the description

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Feb 12, 2020, 13:37

Add clonotype overlap as a distance metric.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Feb 12, 2020, 13:47

[removed]

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 14, 2020, 16:13

changed the description

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 14, 2020, 16:19

mentioned in merge request !10

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 14, 2020, 16:19

assigned to @grst

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 28, 2020, 09:10

marked the task Add clonotype overlap as a distance metric (simple 0-1) as completed

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 28, 2020, 12:51

closed via merge request !10

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 28, 2020, 12:51

mentioned in commit 3c73cbb

@grst grst closed this as completed Apr 9, 2020
This was referenced Apr 9, 2020
grst added a commit that referenced this issue Aug 23, 2020
Feat/tcrdist

Closes #11

See merge request icbi-lab/pipelines/singlecell_tcr!10

Former-commit-id: 200dd159156d880ada06d8a25e190cbcc29219d3
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant